From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E66773E1732 for ; Thu, 2 Jul 2026 10:46:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782989202; cv=none; b=WSwmrK7Y/qJQqTtUHFzyIdDngfVv+YNllthcNAVmz+2+GX6xJ5ghf+U6UPtTPzkUFE41JbMbIvQjt0d2Q+nPWxRR0O6uCpFja+gAwjLtwSkWf+yMbn8h6T+ss0fsfyyCMXKcZ/BPzQJNIsAOYu0gO9c7kqjq3YZrttjVlLS78yU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782989202; c=relaxed/simple; bh=h8ZpqOaUWtsuS4VnVEmZYwH5Jowx/XUHQyg5IY4lRTw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tCCkki57xBA+4CMlVcu/8cVrhLpLyvU+rUwHWLGtEYbJHKFtzsLEP/MOQM/n/nEwsjTRJVYvGZDvic9h3TqlfqdsIxlEBOyffNZbaZdRaAu04ic4/3ZLMhRQTs15sYFB5cwnOZRI5h/YhU06C5muyOX0b6oCw7QLzAFs3rv0UTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P6NMXKNs; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=a7mtvYwp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P6NMXKNs"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="a7mtvYwp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782989199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y8+ItG+n5SavQTNo04OoG8HTpK2q0wv+Unc0gqZ6yGw=; b=P6NMXKNsz663nHc2OiMZOdnVA1WzodjJ1+tgjIyvAvsvhB81KwykGXmHQy8Rm7LbnzmZJj k+D/Njy6Nrj6RCf3wGi6fY3N+ZsLCr56fiGec6aNF9FKHjlyYWj+Lf5hvt6EMe4cBA56Br WZljKIRV6ZIZ35pG+qiHkMk03mHHUXs= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-TOHAljqCOSy1DMEHYYpiJg-1; Thu, 02 Jul 2026 06:46:38 -0400 X-MC-Unique: TOHAljqCOSy1DMEHYYpiJg-1 X-Mimecast-MFC-AGG-ID: TOHAljqCOSy1DMEHYYpiJg_1782989197 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-c127ff955c7so78306166b.1 for ; Thu, 02 Jul 2026 03:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782989197; x=1783593997; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y8+ItG+n5SavQTNo04OoG8HTpK2q0wv+Unc0gqZ6yGw=; b=a7mtvYwpfoZrUQ1CWhsncvnQ7EMl0nKyfAMdr+hU8pzT/DZ5/SI1cvodWFTaIoAWO2 rK0NSQA4YtSO9mRJHLzOmSEAAVFpOMAN5AVUVj/M29M1RUPvfTHHIugwliXMq9GK+clT tcIJO+WHWm36QOpTLukaneeQag3SFWT97UQuqNsZ3ISlb6RrSKh0M+nGeSwkAEe7UzHn 284xD0ExUfrn5T/9yhykQ2NMQK0aNMy7nwL0SqgSEfY91wy2uuQ4JA8jqemAQuBSJPmE iXICrmhtHd0AdVKl9XKVNIBbjvsDVk4GAOe5i70ARxVtcqKnYg++Vpo/D4gdRY0FxLsp Hefg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782989197; x=1783593997; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y8+ItG+n5SavQTNo04OoG8HTpK2q0wv+Unc0gqZ6yGw=; b=YLjcKgh9Z7U2RFZackYTOizruuyQkSzAoy3XRM5U+l2Nxw57tXlj7Vbj7ApRH0F9hZ f4plIUnMCAEY+FQoZtIRvHoGSKfuLFwMCGluL7y4jUfyv2rn/6BLp4+6XenDyi+nTD9w yH1Gwkrfqxd0FNjo+yTwIxiWnf9wU8ytjwwBVuDaN+av1+XTX/s/qsgTn11Y7dwbm3nO NbGuufV/w/Ml7EQ0XM2Jcm0MaK5XdcZIxr5FbtjJcMaNxXcek+LOyD0bJlIyFHBHd1l4 bXJAp3akxj/GjTAzKXmZwrvJZ7YZc9R2noESzeWs9Ph0o+oPkI6jNwAsPTX1iNgYYkbL StAw== X-Forwarded-Encrypted: i=1; AHgh+Rpvma3mqvmWFKOxKpHwoOsIj2hqGcaN6NrFXWSQfD5RlzRNn6AM9GbI17r28dkmPdWX/7lNIh2ZsbFRXmQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3xJ/AzUomq3u93V4KObv76Gbzs2rMx/sioPoPGUQ+HZ6hY2Nd NODXhI4KUvU5bRqwpQVdxo3iPcGyDaKE6f7G/aq6ub9p+CIGHN2i00jsb93vBA0sLL5Wf4usIDg YE4S30CiaiDM5fgLnIWYJuvpU1aZcXGKbsU2V+YlN/DF7OB7DFB4u7frzCDVegQ8kow== X-Gm-Gg: AfdE7cng0cOfdfRnCxyB/GfOT4jUR9aIxAhwGgTszRDkegobrOfLCiVjVwrw7QtpBaC gYo4n6h1ICFwRdqPEHo7n8FbY6EqtusvCXIKS1UTlWzFOvrQ6YAzM1iUso1bcy8HEM+/O24IGPW IWKYEWjwxsqXBLDonQBcPhp4glVX58eVLvn1PAoywMSZNtItLk9xgI0frun6q12/rdvpmWFhh/h KQVAGSynLM5hD+pKXKS6jZqCXW7FWPuU1CEtHYsP38ds5ckKffTjJoA4qb2DhbmdPhyCajH+OLa GvcTLdhH3X+O69CQ6TnEdOfsugPSuDdLJAqz5QZNwfgOrlhWWset0uN2hcvSSK4UBl5IP2Y1GaI Eas3EHTPFzk2+Rdjw52JJduBAMjr1jSgrwoYlIrbyoE9mOCOQWjUUTloHhquTFehxIF45i6CbBX Me7ZB1L8dLEg== X-Received: by 2002:a17:906:818:b0:c12:4ad1:3ec0 with SMTP id a640c23a62f3a-c12aa1f505emr185058866b.54.1782989197352; Thu, 02 Jul 2026 03:46:37 -0700 (PDT) X-Received: by 2002:a17:906:818:b0:c12:4ad1:3ec0 with SMTP id a640c23a62f3a-c12aa1f505emr185057566b.54.1782989196922; Thu, 02 Jul 2026 03:46:36 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:2eb7:f61a:75:4534? ([2a0d:3344:5521:6b10:2eb7:f61a:75:4534]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b62c779dsm108378566b.53.2026.07.02.03.46.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 03:46:36 -0700 (PDT) Message-ID: <2551da86-63d6-4873-93e5-266f29935156@redhat.com> Date: Thu, 2 Jul 2026 12:46:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/10] net: emac: mal: replace busy-wait in mal_poll_disable with wait_event To: Rosen Penev , netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , open list References: <20260630041634.284127-1-rosenp@gmail.com> <20260630041634.284127-6-rosenp@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260630041634.284127-6-rosenp@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/30/26 6:16 AM, Rosen Penev wrote: > @@ -371,8 +373,8 @@ static irqreturn_t mal_int(int irq, void *dev_instance) > void mal_poll_disable(struct mal_instance *mal, struct mal_commac *commac) > { > /* Spinlock-type semantics: only one caller disable poll at a time */ > - while (test_and_set_bit(MAL_COMMAC_POLL_DISABLED, &commac->flags)) > - msleep(1); > + wait_event(commac->poll_wait, > + !test_and_set_bit(MAL_COMMAC_POLL_DISABLED, &commac->flags)); The above looks dangerous to me. IDK which is the expected latency here, but unconditionally spinning without any obvious upper bound and no reschedule does not look good. /P