From: Heiner Kallweit <hkallweit1@gmail.com>
To: Tong Chen <tongchen@whu.edu.cn>
Cc: nic_swsd@realtek.com, davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: reduce the param length of the line
Date: Tue, 1 Sep 2020 09:29:43 +0200 [thread overview]
Message-ID: <2552dde8-7d2a-03f9-79cc-07dd506d8b41@gmail.com> (raw)
In-Reply-To: <20200901022811.8675-1-tongchen@whu.edu.cn>
On 01.09.2020 04:28, Tong Chen wrote:
> Reduce the param length of the line from 79 chars to 52 chars,
> which complies with kernel preferences.
Apart from formal issues with the patch (missing net/net-next
annotation, wrong prefix): Did you get a checkpatch warning?
Or what's the source of your assumed kernel preference?
> Signed-off-by: Tong Chen <tongchen@whu.edu.cn>
> ---
> drivers/net/ethernet/realtek/r8169_phy_config.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169_phy_config.c b/drivers/net/ethernet/realtek/r8169_phy_config.c
> index 913d030d73eb..f4b738cf8ad7 100644
> --- a/drivers/net/ethernet/realtek/r8169_phy_config.c
> +++ b/drivers/net/ethernet/realtek/r8169_phy_config.c
> @@ -1302,7 +1302,8 @@ static void rtl8125b_hw_phy_config(struct rtl8169_private *tp,
> rtl8125b_config_eee_phy(phydev);
> }
>
> -void r8169_hw_phy_config(struct rtl8169_private *tp, struct phy_device *phydev,
> +void r8169_hw_phy_config(struct rtl8169_private *tp,
> + struct phy_device *phydev,
> enum mac_version ver)
> {
> static const rtl_phy_cfg_fct phy_configs[] = {
>
prev parent reply other threads:[~2020-09-01 7:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 2:28 Tong Chen
2020-09-01 7:29 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2552dde8-7d2a-03f9-79cc-07dd506d8b41@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=tongchen@whu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome