From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933270AbcECMNP (ORCPT ); Tue, 3 May 2016 08:13:15 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:56430 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932517AbcECMNN (ORCPT ); Tue, 3 May 2016 08:13:13 -0400 From: Arnd Bergmann To: Liviu.Dudau@arm.com Cc: Thierry Reding , Bjorn Helgaas , catalin.marinas@arm.com, linux-pci@vger.kernel.org, will.deacon@arm.com, Lorenzo Pieralisi , Tomasz Nowicki , ddaney@caviumnetworks.com, robert.richter@caviumnetworks.com, msalter@redhat.com, jchandra@broadcom.com, linux-kernel@vger.kernel.org, hanjun.guo@linaro.org, Suravee.Suthikulpanit@amd.com Subject: Re: [PATCH 1/3] [RFC] pci: add new method for register PCI hosts Date: Tue, 03 May 2016 14:12:34 +0200 Message-ID: <2557793.QTjSAUMHc9@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160503100422.GZ28464@e106497-lin.cambridge.arm.com> References: <1461970899-4150603-1-git-send-email-arnd@arndb.de> <20160502070943.GB27465@ulmo.ba.sec> <20160503100422.GZ28464@e106497-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:xHNgmjsYBNAAzR0imq3jZnJHkuqUJLHqmTLJGmt4mep2rlfdXTl Q+t+XogMAYos7bpRF79snneGKB5GhTP2/Wbisy6Vln5kubFIbFXj0mwLsmpdjNe2TL/8JSR qeUP8pVwbBHrtCQJt93p2Nvf7imZzlZzoUZn+B8CXQGDizFuFhTnCAQkAN+LlLAMVYUiiVa p3GtZAnXYybOpaWOb/gNQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:iTnrQMegw64=:bjCNPzSuAmmlV5dos4VgWT bPI8P8VPO5bCo+ZTBB+H1oBrZWeGr+OsgDXikHetT3epKDtZG6D0fJuslnm0hVLQvngVLKBjs K8gF6Mqc/3cDEM/XLdGiruP8KeBj9kR+jsPVBNVlFQ/cCqEtPCl0k1z12v+QeBFBU4btm3sfv 15EbJc/pLvJNtCXdUOsXN5vrSdG9YPSUK7XPQIf3dE0aRdFkk8I7o71dYaw9MK9qYRDmylwJw wzIk2Oe2DO0mbSL3J/Kw+JPQSMLMTsE6whC0WYqsCdocb4NaPOkMV9Ag3vUjEW6cYnJfbtCy7 NmRi1YuHOMgqnmuwptJjMhsqhcAWlgBmSJaKl0IqW8B3jKCn/gMFf2wZsplqOcgGhSHqJ71t0 C6iJkImFIapsH9sd2QPxPsFLQAAbPUpZocLsl/8iYX6lPxtRm8zAiWaHug6etDzc/e6T0/yqL qW9kmCZx+RfU7/SYqxFrBMT2+DZpDZWmmxB4INESW5KYK5i35IB5Sq0nyoJJV/DNqDjqbclOA EqVsrQ0PA8FW+cR+Rsvw+qtfoWVkm5VuTT0VHVHSXuh6OT1ZpksODDFHz/2Any45E60pkiS0/ O7IbAGEkRuYChHauVJ2DpygUjX6c+5zSvkIz8dPPOCvs5MZ6k8Nd6LIv2V6fLTaahbfKCUZJP gQ3ZXf3f51E0czEFYYBv6JfSBaunTAbT2EheQXg2a8IYhYhF5BxlKVTWozPZyIAquLqUB0Qpl 7WsWIULZ2JHvXTaB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 03 May 2016 11:04:23 Liviu.Dudau@arm.com wrote: > > > + list_splice_init(&bridge->windows, &resources); > > > + b->sysdata = bridge->sysdata; > > > > Does the sysdata not become effectively obsolete after this series? My > > understanding is that it's primarily used to store driver-specific data > > along with a PCI bus, but if drivers can embed struct pci_host_bridge > > they can simply upcast bus->bridge. > > I second that. If we do this change (which is long overdue and I fully support), > let's kill sysdata now. Generic host bridge code doesn't use sysdata on purpose. I think we still need it in the intermediate time for any remaining users of the existing interfaces (pci_scan_bus, pci_scan_root_bus, pci_create_root_bus). It may take a while until those are all gone, but I agree that it makes sense to not even set the pointer for any driver we convert to the new interface. Arnd