From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Stratos Karafotis <stratosk@semaphore.gr>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings
Date: Wed, 30 Apr 2014 22:16:14 +0200 [thread overview]
Message-ID: <2559921.qEXZdngR08@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohponkTeEqdgqJ6+caQcKd5yoMNhFvkZib1UueqNBCmO=pmA@mail.gmail.com>
On Wednesday, April 30, 2014 09:34:03 AM Viresh Kumar wrote:
> On 30 April 2014 04:09, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > It should be cleaned up generally, so if you have the time and you're willing
> > to do such things, please do them.
> >
> > That said things like lines in excess of 80 characters may stay as they are.
>
> I have tried this sort of stuff earlier, but there is one issue that stands
> up again and again. When you update neighboring lines of lines
> crossing 80 columns, we do get warnings for lines which aren't actually
> updated by us (from checkpatch.pl). So, probably we need to fix
> checkpatch then..
That has been my opinion pretty much forever.
Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2014-04-30 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 21:13 Stratos Karafotis
2014-04-23 4:46 ` Viresh Kumar
2014-04-23 13:51 ` Stratos Karafotis
2014-04-23 10:37 ` Rafael J. Wysocki
2014-04-23 13:53 ` Stratos Karafotis
2014-04-29 22:39 ` Rafael J. Wysocki
2014-04-30 4:04 ` Viresh Kumar
2014-04-30 20:16 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2559921.qEXZdngR08@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=stratosk@semaphore.gr \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®