From: Krzysztof Kozlowski <krzk@kernel.org>
To: Joan-Na-adi <joan.na.devcode@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Joan Na <joan.na@analog.com>
Subject: Re: [PATCH v7 2/2] regulator: max77675: Add MAX77675 regulator driver
Date: Fri, 5 Dec 2025 08:52:39 +0100 [thread overview]
Message-ID: <2559bbc4-290b-456b-80d1-1b188d98b046@kernel.org> (raw)
In-Reply-To: <20251205045648.3725-3-joan.na@analog.com>
On 05/12/2025 05:56, Joan-Na-adi wrote:
> +
> + if (int_glbl & MAX77675_INT_EN_R_BIT)
> + dev_dbg(maxreg->dev, "nEN Rising Edge Interrupt occurred\n");
> +
> + if (int_glbl & MAX77675_INT_EN_F_BIT)
> + dev_dbg(maxreg->dev, "nEN Falling Edge Interrupt occurred\n");
> +
> + return 0;
> +}
> +
> +static int max77675_regulator_probe(struct i2c_client *client)
> +{
> + struct max77675_regulator *maxreg;
> + struct regulator_config config = {};
> + struct device_node *regulators_np __free(device_node) = NULL;
This is an undesired syntax explicitly documented as one to avoid. You
need here proper assignment, not NULL. Please don't use cleanup.h if you
do not intend to follow it because it does not make the code simpler.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-12-05 7:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 4:56 [PATCH v7 0/2] Add support for MAX77675 device Joan-Na-adi
2025-12-05 4:56 ` [PATCH v7 1/2] regulator: dt-bindings: Add MAX77675 regulator Joan-Na-adi
2025-12-06 10:59 ` Krzysztof Kozlowski
2025-12-05 4:56 ` [PATCH v7 2/2] regulator: max77675: Add MAX77675 regulator driver Joan-Na-adi
2025-12-05 7:52 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2559bbc4-290b-456b-80d1-1b188d98b046@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joan.na.devcode@gmail.com \
--cc=joan.na@analog.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®