From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F29C4167B for ; Thu, 7 Dec 2023 16:59:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442950AbjLGQ6z (ORCPT ); Thu, 7 Dec 2023 11:58:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233096AbjLGQ6x (ORCPT ); Thu, 7 Dec 2023 11:58:53 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6650410F1 for ; Thu, 7 Dec 2023 08:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=PWfCkxqh69JRaN0uLniA1Rm+AJPpbgE/QsqQDXSaKlM=; b=z/FKr7Pf8NE5S99CVKNCqFSjs+ GFSjSBU5ja8OHmH8myNQMCjl56Brc9OM8fxZv/FdDjSz784vhnIiv7e3R6UkYaS/7Na+r2wscwdGk PAWJqVgmqYJGdc9hwB+KVpN8+0L9AvCDPLY2uZropYDYTcpUNBYJXUwasfpZ1X/L7OWITqz5X5IBR qwL6sAT3K7taYd0fNn9HhMPTnnRh079cP/Ctya1QdDiakCSO18ExnQGeo6Nw5ybKNXTU83uTX/NPZ QtPRHkqJxfN2Ar7Izr4acip4ffpcyLw0yF2ZF0+O5aMV4HdCsFwdmMnSoMPxz1ySC1Ineg3R83x+p 3Qe98vsQ==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rBHiA-00DSlD-1a; Thu, 07 Dec 2023 16:58:54 +0000 Message-ID: <255a12ae-78a1-4e5a-b39a-c990aefba91a@infradead.org> Date: Thu, 7 Dec 2023 08:58:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/panel: re-alphabetize the menu list Content-Language: en-US To: Aradhya Bhatia , linux-kernel@vger.kernel.org Cc: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org References: <20231207062233.5318-1-rdunlap@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/7/23 01:52, Aradhya Bhatia wrote: > Hi Randy, > > Thanks for the patch! > > On 07/12/23 11:52, Randy Dunlap wrote: >> A few of the DRM_PANEL entries have become out of alphabetical order, >> so move them around a bit to restore alpha order. >> >> Signed-off-by: Randy Dunlap >> Cc: Neil Armstrong >> Cc: Jessica Zhang >> Cc: Sam Ravnborg >> Cc: Maarten Lankhorst >> Cc: Maxime Ripard >> Cc: Thomas Zimmermann >> Cc: David Airlie >> Cc: Daniel Vetter >> Cc: dri-devel@lists.freedesktop.org >> --- >> drivers/gpu/drm/panel/Kconfig | 90 ++++++++++++++++---------------- >> 1 file changed, 45 insertions(+), 45 deletions(-) >> >> diff -- a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig >> --- a/drivers/gpu/drm/panel/Kconfig >> +++ b/drivers/gpu/drm/panel/Kconfig >> @@ -95,34 +95,6 @@ config DRM_PANEL_LVDS >> handling of power supplies or control signals. It implements automatic >> backlight handling if the panel is attached to a backlight controller. >> >> -config DRM_PANEL_SIMPLE >> - tristate "support for simple panels (other than eDP ones)" >> - depends on OF >> - depends on BACKLIGHT_CLASS_DEVICE >> - depends on PM >> - select VIDEOMODE_HELPERS >> - help >> - DRM panel driver for dumb non-eDP panels that need at most a regulator >> - and a GPIO to be powered up. Optionally a backlight can be attached so >> - that it can be automatically turned off when the panel goes into a >> - low power state. >> - >> -config DRM_PANEL_EDP >> - tristate "support for simple Embedded DisplayPort panels" >> - depends on OF >> - depends on BACKLIGHT_CLASS_DEVICE >> - depends on PM >> - select VIDEOMODE_HELPERS >> - select DRM_DISPLAY_DP_HELPER >> - select DRM_DISPLAY_HELPER >> - select DRM_DP_AUX_BUS >> - select DRM_KMS_HELPER >> - help >> - DRM panel driver for dumb eDP panels that need at most a regulator and >> - a GPIO to be powered up. Optionally a backlight can be attached so >> - that it can be automatically turned off when the panel goes into a >> - low power state. >> - >> config DRM_PANEL_EBBG_FT8719 >> tristate "EBBG FT8719 panel driver" >> depends on OF >> @@ -317,12 +289,6 @@ config DRM_PANEL_LEADTEK_LTK500HD1829 >> 24 bit RGB per pixel. It provides a MIPI DSI interface to >> the host and has a built-in LED backlight. >> >> -config DRM_PANEL_SAMSUNG_LD9040 >> - tristate "Samsung LD9040 RGB/SPI panel" >> - depends on OF && SPI >> - depends on BACKLIGHT_CLASS_DEVICE >> - select VIDEOMODE_HELPERS >> - >> config DRM_PANEL_LG_LB035Q02 >> tristate "LG LB035Q024573 RGB panel" >> depends on GPIOLIB && OF && SPI >> @@ -350,6 +316,17 @@ config DRM_PANEL_MAGNACHIP_D53E6EA8966 >> with the Magnachip D53E6EA8966 panel IC. This panel receives >> video data via DSI but commands via 9-bit SPI using DBI. >> >> +config DRM_PANEL_MANTIX_MLAF057WE51 >> + tristate "Mantix MLAF057WE51-X MIPI-DSI LCD panel" >> + depends on OF >> + depends on DRM_MIPI_DSI >> + depends on BACKLIGHT_CLASS_DEVICE >> + help >> + Say Y here if you want to enable support for the Mantix >> + MLAF057WE51-X MIPI DSI panel as e.g. used in the Librem 5. It >> + has a resolution of 720x1440 pixels, a built in backlight and touch >> + controller. >> + >> config DRM_PANEL_NEC_NL8048HL11 >> tristate "NEC NL8048HL11 RGB panel" >> depends on GPIOLIB && OF && SPI >> @@ -438,17 +415,6 @@ config DRM_PANEL_NOVATEK_NT39016 >> Say Y here if you want to enable support for the panels built >> around the Novatek NT39016 display controller. >> >> -config DRM_PANEL_MANTIX_MLAF057WE51 >> - tristate "Mantix MLAF057WE51-X MIPI-DSI LCD panel" >> - depends on OF >> - depends on DRM_MIPI_DSI >> - depends on BACKLIGHT_CLASS_DEVICE >> - help >> - Say Y here if you want to enable support for the Mantix >> - MLAF057WE51-X MIPI DSI panel as e.g. used in the Librem 5. It >> - has a resolution of 720x1440 pixels, a built in backlight and touch >> - controller. >> - >> config DRM_PANEL_OLIMEX_LCD_OLINUXINO >> tristate "Olimex LCD-OLinuXino panel" >> depends on OF >> @@ -566,6 +532,12 @@ config DRM_PANEL_SAMSUNG_DB7430 >> DB7430 DPI display controller used in such devices as the >> LMS397KF04 480x800 DPI panel. >> >> +config DRM_PANEL_SAMSUNG_LD9040 >> + tristate "Samsung LD9040 RGB/SPI panel" >> + depends on OF && SPI >> + depends on BACKLIGHT_CLASS_DEVICE >> + select VIDEOMODE_HELPERS >> + >> config DRM_PANEL_SAMSUNG_S6D16D0 >> tristate "Samsung S6D16D0 DSI video mode panel" >> depends on OF >> @@ -774,6 +746,34 @@ config DRM_PANEL_STARTEK_KD070FHFID015 >> with a resolution of 1024 x 600 pixels. It provides a MIPI DSI interface to >> the host, a built-in LED backlight and touch controller. >> >> +config DRM_PANEL_EDP >> + tristate "support for simple Embedded DisplayPort panels" >> + depends on OF >> + depends on BACKLIGHT_CLASS_DEVICE >> + depends on PM >> + select VIDEOMODE_HELPERS >> + select DRM_DISPLAY_DP_HELPER >> + select DRM_DISPLAY_HELPER >> + select DRM_DP_AUX_BUS >> + select DRM_KMS_HELPER >> + help >> + DRM panel driver for dumb eDP panels that need at most a regulator and >> + a GPIO to be powered up. Optionally a backlight can be attached so >> + that it can be automatically turned off when the panel goes into a >> + low power state. >> + > > I don't think you intended to put PANEL_EDP this down the file! But just > in case if you did, why? I was alphabetizing on "support for simple" on the entry above and the one below. Even without "support for", they would read as "Simple ... panels". > Regards > Aradhya > >> +config DRM_PANEL_SIMPLE >> + tristate "support for simple panels (other than eDP ones)" >> + depends on OF >> + depends on BACKLIGHT_CLASS_DEVICE >> + depends on PM >> + select VIDEOMODE_HELPERS >> + help >> + DRM panel driver for dumb non-eDP panels that need at most a regulator >> + and a GPIO to be powered up. Optionally a backlight can be attached so >> + that it can be automatically turned off when the panel goes into a >> + low power state. >> + >> config DRM_PANEL_TDO_TL070WSH30 >> tristate "TDO TL070WSH30 DSI panel" >> depends on OF -- ~Randy