From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750906AbbCDWvH (ORCPT ); Wed, 4 Mar 2015 17:51:07 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:60465 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbbCDWvF (ORCPT ); Wed, 4 Mar 2015 17:51:05 -0500 From: Arnd Bergmann To: Arun Ramamurthy Cc: Ray Jui , linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, a.zummo@towertech.it, sbranden@broadcom.com, pawel.moll@arm.com, devicetree@vger.kernel.org, ijc+devicetree@hellion.org.uk, Arun Ramamurthy , linux-kernel@vger.kernel.org, grant.likely@linaro.org, robh+dt@kernel.org, bcm-kernel-feedback-list@broadcom.com, galak@codeaurora.org, rtc-linux@googlegroups.com Subject: Re: [PATCHv1] rtc: bcm-iproc: Add support for Broadcom iproc rtc Date: Wed, 04 Mar 2015 23:50:10 +0100 Message-ID: <2569223.1gDQjv8f8j@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <54F789CD.5030504@broadcom.com> References: <1418757750-3628-1-git-send-email-arun.ramamurthy@broadcom.com> <3699327.0G6ZNxn8QA@wuerfel> <54F789CD.5030504@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:B+o/1dZw1LnpcqlXDFsos0EzBape06Pzf8Y1yY6qHUpJ4W+kIWO MS1GP/58EnBG1gmMlaChDxN3ARbslUbVjSHSJQod7BV+qANDcPOYt7tupvHtklyte1mw7Kf Uns5k7ENBRi658oWkOv9TREN3+7K+uI986IPif3VKBmZig152t2mYF3pbg8wJGtZ4wFCntw DGtVpsXzgpc7GErQOdKEQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 04 March 2015 14:40:13 Arun Ramamurthy wrote: > On 15-03-04 02:21 PM, Arnd Bergmann wrote: > > On Thursday 12 February 2015 14:17:41 Arun Ramamurthy wrote: > >> Hi Arnd > >> > >> My apologies for the late reply, I was moved to other work items. I > >> wanted to get more clarification on the syscon issue so that I can > >> submit the next patch set. If I understand correctly, you would like > >> me to move the CRMU logic to a new driver under mfd/ and use the syscon > >> api calls in my rtc driver? Thanks > > > > It depends a lot on what's in there, I can best advise you if you > > have some form of register list. > > > > A common approach would be to not have a driver for the crmu at all, > > but just mark it as syscon, and have the other drivers either reference > > the syscon node through a phandle, or create them as childrem of > > the syscon node. The latter case makes most sense if all uses of > > the crmu have no other MMIO registers. > > > > Thank you Arnd, I am going to follow the approach of adding a child node > to the syscon node. Several other driver use other registers in the CRMU > so I think the child node approach makes the most sense. Just to be sure we have the same understanding: of those other drivers, do you think that they would use only CRMU registers, or could there be drivers that have both CRMU as well as other MMIO registers? Arnd