From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8428C433EF for ; Fri, 20 May 2022 16:32:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351670AbiETQcZ (ORCPT ); Fri, 20 May 2022 12:32:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351657AbiETQcT (ORCPT ); Fri, 20 May 2022 12:32:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 85AEB16D5E8 for ; Fri, 20 May 2022 09:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653064336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FGJBElcZPrcyPm9iaZsEnyI0bOLSeVcTHjfVRje6MJg=; b=MsqAR06yx3+M4eotDN8ZMngjZWa9h08l7iXzzQj2Jt5WVkxIk1FqMkA7i66rGpbetj1R4/ 5U6wmc1SA/ELipcZpINtSpq7EOQoMw9ijqsXMSqeoyN46+UMp60/AtBM/BdVOX6y8CHVqt jfAxrWdGOyUMzVtTZ9ksxJCDwce+/DM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557-qn05oFlGPzO6mLbN2bdRIA-1; Fri, 20 May 2022 12:32:14 -0400 X-MC-Unique: qn05oFlGPzO6mLbN2bdRIA-1 Received: by mail-wm1-f72.google.com with SMTP id q128-20020a1c4386000000b003942fe15835so3347608wma.6 for ; Fri, 20 May 2022 09:32:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=FGJBElcZPrcyPm9iaZsEnyI0bOLSeVcTHjfVRje6MJg=; b=XhC3o9q4lCj2zI7gDtaL3L/K0Xgi66RrL1JVWevglOijDEJSFLVTx4gBwOHXU3p+6Z GrLty3WWKZAOWJX4fEIfDkVcwCG4x9vH44SS+vLx9U82det4rAwEQ4idbwlZ7R61/psk EpfMDu9UMqZN8wN8zbAZ/5DIOtciyICi+ic5Ir9HSkOdJnWgopKlRyzEUzU+/qmxVeHc V9RnW5RZm4Qf9Uggnkrhzh+OoOhZwu0MOxNh/pDVgRFOO5fcVXwoPPw/+Mtbw6G4DcZV 8rS12UNQ2f93khf6pQvj1CQrRzLooipO1h/QBRzWBjs9/OwXAzgeyD/6brw2UqUiv6qA E6PA== X-Gm-Message-State: AOAM532Y/jGND2NmD6QzDO/TZ6gbWNTNLbtE35zFF7bC/vBARhKwkNNe GPH0CCmLD1dmPcD0iji5N5C5ZuxTD4pNC1eT9m4EaETHmDtiHCQdDm+64qToP9iDM3UbCt9LnCm aq7vPki2owyrS2vXVUhFILY9I X-Received: by 2002:a5d:4988:0:b0:20d:9b8:e560 with SMTP id r8-20020a5d4988000000b0020d09b8e560mr9007685wrq.33.1653064333586; Fri, 20 May 2022 09:32:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGxw0Xn89Aa2qNKN8E38RWkK+y15l4x06OBHYokJ+KNOFPYErCxw/yS6hQL2c4SkQOKm3Qow== X-Received: by 2002:a5d:4988:0:b0:20d:9b8:e560 with SMTP id r8-20020a5d4988000000b0020d09b8e560mr9007660wrq.33.1653064333363; Fri, 20 May 2022 09:32:13 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id m26-20020a7bce1a000000b003942a244f3fsm2669762wmc.24.2022.05.20.09.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 09:32:13 -0700 (PDT) Message-ID: <256e0b82-5d0f-cf40-87c6-c2505d2a6d3b@redhat.com> Date: Fri, 20 May 2022 18:32:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH V11 09/22] LoongArch: Add boot and setup routines Content-Language: en-US To: Huacai Chen Cc: Ard Biesheuvel , Huacai Chen , Arnd Bergmann , Andy Lutomirski , Thomas Gleixner , Peter Zijlstra , Andrew Morton , David Airlie , Jonathan Corbet , Linus Torvalds , linux-arch , Linux Doc Mailing List , Linux Kernel Mailing List , Xuefeng Li , Yanteng Si , Guo Ren , Xuerui Wang , Jiaxun Yang , Stephen Rothwell , linux-efi References: <20220518092619.1269111-1-chenhuacai@loongson.cn> <20220518092619.1269111-10-chenhuacai@loongson.cn> <0bae0df1-48ae-d02f-bce4-d1f69acf269e@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/20/22 17:19, Huacai Chen wrote: > Hi, Javier, [snip] >> Conversely, if the sysfb_init() is executed first then the platform device >> will be registered and latter when the driver's init register the driver >> this will match the already registered device. > Yes, you are right, my consideration is too complex. The only real > problem is a harmless error "efifb: a framebuffer is already > registered" when both efifb and the native display driver are > built-in. > But this shouldn't be a problem if you drop your register_gop_device() that registers an "efi-framebuffer", since sysfb would either register a platform device "simple-framebufer" or "efi-framebuffer", but never both. Those are mutually exclusive. I think what's happening now is that sysfb is registering a "simple-framebuffer" but your register_gop_device() function is also registering an "efi-framebuffer". -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat