From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761793AbcIXJTz (ORCPT ); Sat, 24 Sep 2016 05:19:55 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:57677 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761553AbcIXJTx (ORCPT ); Sat, 24 Sep 2016 05:19:53 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: Greg KH , wsa@the-dreams.de, Bhumika Goyal , dan.carpenter@oracle.com, Julia Lawall , weiyongjun1@huawei.com, sayli karnik , devel@driverdev.osuosl.org, xie.baoyou@zte.com.cn, Linux Kernel Mailing List Subject: Re: [PATCH 1/2] Staging: ks7010: mark symbols static where possible Date: Sat, 24 Sep 2016 11:14:03 +0200 Message-ID: <2571045.85xaKF6mvo@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1474636949-10297-1-git-send-email-baoyou.xie@linaro.org> <20160923171020.GA28694@kroah.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:akPpSi/YERZKyug0WiIbeljPuKKrgFjnV8TS9CGTZm4KU/EMH16 mGnN9oFkkBVuBZ3Z7lNvzl2B0e/xXiPiwJI1uQnbpz2ZdBgXf2c/ptlIObimpe5sw7CMsSw ODNuqQS/oF/Y9NB6GVluAgo4grWcj9ATibd9MNQFp/LwPjwOTrIkFhGIL3y0p0gPS9hAoqs Bj+svKH73KGRPBZ2pcNpA== X-UI-Out-Filterresults: notjunk:1;V01:K0:keLZh2mRyNk=:Gnd2Ob8GyvWXzVqiutF/Tk ylmt0oxBMsae0QS/pxP9DeueTfjOc3NAi5Q+Mph1yiH15tyz3p/1asKyCSy7JSEU7u2wDtq4k ilKKvJl+e+1BVOsbDCLrUBU9ic7cTUlmhHynPXjky+JkyZ0x4KlFqUQlAXw/pEApw/PMH9VO0 ajnEsaBHdq+wSO43BjZeBeAwJ270w9n2cibQTHP7AuEDuJEkmIRoSCEyLp3QrQfFyFy0HMY7R 60XaFtT4JUSHy8tKX84sS+N7f3EdCEWL99lbbwLwpdc+yaDEq4XqVAA373jOEmMN/nkCajbEI tm6t2CyY5nmCtC9QHmq0KKJZ2DJUCUl0yT5zMt2bIaaCkJzCjij3vCazJvT17vqj2OAZ++kcI ll0PvW0WX6itz0Hjj/mIJgqHw0Y+cc0bLBOHcieZvqIErfZHyDaKWC9/omZhmhB/mlKYdBHE9 rpDiX5vA/6P8V22lnEUmxnk2YmaY0qi6Od2JM11reE8OfLByWeKpqGnzys9HYEUiqRxiXRZTx uD8v5QHjOKLWJH0kx0POVFT7vcGLdK6VihL325J+nkdEOD0rHbQPsnyPcC9CEVzxs5Kkg2ine sFGVv4TMUpx1x8khPAzrmpAPDJeUulbqjeMArpU14l7PsNVU+5JCy3ln0Okb3BQQwZCZzuVU+ FeZswtxP7kJLICLiV48hRt+o7RmRli1Ye6DT3AHkPVCzXdlpQb+ovihXTIFSgZ+y/0AB/+mZq rIqL4KCHriTVCt4V Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, September 24, 2016 9:34:41 AM CEST Baoyou Xie wrote: > On 24 September 2016 at 01:10, Greg KH wrote: > > > On Fri, Sep 23, 2016 at 09:22:29PM +0800, Baoyou Xie wrote: > > > We get 3 warnings when building kernel with W=1: > > > drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous > > prototype for 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes] > > > drivers/staging/ks7010/ks7010_sdio.c:120:6: warning: no previous > > prototype for 'ks_wlan_hw_sleep_wakeup_request' [-Wmissing-prototypes] > > > drivers/staging/ks7010/ks7010_sdio.c:172:5: warning: no previous > > prototype for '_ks_wlan_hw_power_save' [-Wmissing-prototypes] > > > > > > In fact, these functions are only used in the file in which they are > > > declared and don't need a declaration, but can be made static. > > > so this patch marks these functions with 'static'. > > > > > > Signed-off-by: Baoyou Xie > > > --- > > > drivers/staging/ks7010/ks7010_sdio.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Does not apply cleanly, are you sure you are using the latest tree? > > > I worked on linux next-20160922 tag, could you tell me how to find the > valid tree? The file saw a couple of small changes in next-20160923, so I think this was just unfortunate timing but you used the right tree. staging can be moving very rapidly at times, so if you want to be sure to get the right tree of the minute, you can rebase on top of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing I usually just base on top of the linux-next of the day, which tends to work well enough. Arnd