mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Cc: lars@metafoo.de, Matt Ranostay <mranostay@gmail.com>
Subject: Re: [PATCHv2 1/2] iio: Documentation: Add proximity unit
Date: Sat, 14 Jan 2017 12:58:12 +0000	[thread overview]
Message-ID: <2571c4a3-8fec-14e1-5fed-072c1f3c7d44@kernel.org> (raw)
In-Reply-To: <20170111155139.6559-1-enric.balletbo@collabora.com>

On 11/01/17 15:51, Enric Balletbo i Serra wrote:
> To follow iio guidelines Where possible we stick to the raw SI unit, so
> specify meters for proximity.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Please remember to add a change log to later versions of patch sets.
Saves reviewers who typically have the memory of goldfish (well I do
anyway) having to read old emails to check what they found last time!

This patch is fine on it's own.  Effectively allows us to drop the
custom attribute description in sysfs-bus-iio-proximit-as3935 as well.
(Matt cc'd)

Applied to the togreg branch of iio.git.

Thanks,

Jonathan

> ---
>  Documentation/ABI/testing/sysfs-bus-iio | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index b8f220f..1bd8ed1 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -1245,7 +1245,8 @@ Description:
>  		reflectivity of infrared or ultrasound emitted.
>  		Often these sensors are unit less and as such conversion
>  		to SI units is not possible. Higher proximity measurements
> -		indicate closer objects, and vice versa.
> +		indicate closer objects, and vice versa. Units after
> +		application of scale and offset are meters.
>  
>  What:		/sys/.../iio:deviceX/in_illuminance_input
>  What:		/sys/.../iio:deviceX/in_illuminance_raw
> 

      parent reply	other threads:[~2017-01-14 12:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 15:51 Enric Balletbo i Serra
2017-01-11 15:51 ` [PATCHv2 2/2] iio: cros_ec_light_prox: add ChromeOS EC Light and Proximity Sensors Enric Balletbo i Serra
2017-01-14 13:06   ` Jonathan Cameron
2017-01-20 14:23     ` Enric Balletbo Serra
2017-01-23 18:18       ` Gwendal Grignou
2017-01-27 10:42         ` Enric Balletbo Serra
2017-01-28 12:10           ` Jonathan Cameron
2017-01-28 12:07         ` Jonathan Cameron
2017-01-14 12:58 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2571c4a3-8fec-14e1-5fed-072c1f3c7d44@kernel.org \
    --to=jic23@kernel.org \
    --cc=enric.balletbo@collabora.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mranostay@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®