From: Benjamin Coddington <bcodding@redhat.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH -next v3 1/2] sunrpc: Wrap read accesses to rpc_task.tk_pid
Date: Mon, 16 Oct 2023 17:15:01 -0400 [thread overview]
Message-ID: <25740B27-9C85-46D9-8ACF-17D45D56A014@redhat.com> (raw)
In-Reply-To: <fb3bd4ed540bbe18f60bf1f700c110d662533503.1697460614.git.geert+renesas@glider.be>
On 16 Oct 2023, at 9:09, Geert Uytterhoeven wrote:
> The tk_pid member in the rpc_task structure exists conditionally on
> debug or tracing being enabled.
>
> Introduce and use a wapper to read the value of this member, so users
> outside tracing no longer have to care about these conditions.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310121759.0CF34DcN-lkp@intel.com/
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
I never work on kernels that don't have tk_pid, but I can say its so useful
that for 2 out of the 224 bytes that rpc_task uses (on aarch64), I'd be
inclined to just include it all the time. That way its around for folks to
reference with realtime tools (like bpftrace, stap).
Does anyone know if there is a good reason not to include it for all
configurations?
Ben
..also:
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
next prev parent reply other threads:[~2023-10-16 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 13:09 [PATCH -next v3 0/2] sunrpc: Fix W=1 compiler warnings Geert Uytterhoeven
2023-10-16 13:09 ` [PATCH -next v3 1/2] sunrpc: Wrap read accesses to rpc_task.tk_pid Geert Uytterhoeven
2023-10-16 21:15 ` Benjamin Coddington [this message]
2023-10-17 6:35 ` Geert Uytterhoeven
2023-10-16 13:09 ` [PATCH -next v3 2/2] sunrpc: Use no_printk() in dfprintk*() dummies Geert Uytterhoeven
2023-10-16 21:16 ` Benjamin Coddington
2023-10-19 7:56 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25740B27-9C85-46D9-8ACF-17D45D56A014@redhat.com \
--to=bcodding@redhat.com \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=geert+renesas@glider.be \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=tom@talpey.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®