From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754676AbbIRV2f (ORCPT <rfc822;w@1wt.eu>);
	Fri, 18 Sep 2015 17:28:35 -0400
Received: from mout.kundenserver.de ([212.227.126.131]:65427 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753463AbbIRV2d (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 18 Sep 2015 17:28:33 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Ray Jui <rjui@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/9] ARM: dts: consolidate aliases for Cygnus dt files
Date: Fri, 18 Sep 2015 23:27:37 +0200
Message-ID: <25764744.UdkoAR05y0@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1442611454-16331-2-git-send-email-rjui@broadcom.com>
References: <1442611454-16331-1-git-send-email-rjui@broadcom.com> <1442611454-16331-2-git-send-email-rjui@broadcom.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:V8D9T0dCQOPCYXETgkk8wqL55wfuuWdm0JuIkd3K6JtUjD9VbVo
 t3VNYs5NBtwQ34WWuRvbdE9874E0IOx/ypRsN/fxvuT3axQPNz9FwM4qr3Jl8xlMPGVIE6R
 u+8cQncg2WxkCcqDyJuhvWYgQK4Sm/uUNBkuNKGkQnaHQmcBI1lY/p/nnKeVXENvhZaRYco
 3aQ5h4DsEFuzsaspXKfBQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:tsLa4ZsOhz8=:Ews0AXC7MInXgJW1OoA/Jj
 G4PV3o9RbZWnso9SMu3/w9DQfwqcPEDJEDSFTucc+pLRKqMUP0Z8TBBg885nJI39TF3o8RsWb
 hdNVPUDnbCnSqNMSK3guVU3NU1DGQN1asUxmHi3ws07caYaxPQSuzkfK+WoIBZ/ht3dnZGfGS
 erCjMjcQrZcPzK4YdK+zAAGGcHZPmJ3KKQkp30A6b/fBcgBz6Ldd9ih+/2U8adMUzt4s+YHrn
 8TS64gL6w7/zWzma6q15AQ4fS6jYaBIAjSH0qyljFKEIW3tKQ3hTcQAL4OBJ/MCX/JnIhABBT
 QRAM9TJhjk/tG1p85vUvrU9/rD6b+3k8upwEeAK+c4pigoaCM0J4Y6CKqlg+HACKtdj+Yd5PP
 bUy4YhWc4Bx4bT1pfR2IinWAKY1ZEQe8UHx5vfVJlEiAT3Evfm+15yWfv/NXch5fgN+fhK8hy
 ENVNYfoH68kUSTe+fCBJ15oPcRYPa+A6ErURli1aNQuj4Jc2dBmTeu6ghOWAaSEOrCwyLW+Dc
 DtIliphSPdftbnz9jEmUkA0GZwi3jwhTZ0VT0dWEK8Q3OY57FPwsg1o6AiuIsQJJwMzJulUdF
 naZhamgUNYgXJlv2uMsWkl9ioa6qDjEPI9qLHxGbZNjczjqlVp82QVseE4Wh2dJJyHbP9c/ti
 e1WFztbJjC6JObTvV082CWPhEVxTlg1YEnJ+dfQkbgwkIg1IyCPyL59aTsm8qCPukmnUer1I4
 28iOujhkhX9ZZpBz
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 18 September 2015 14:24:06 Ray Jui wrote:
> Move aliases into bcm-cygnus.dtsi to avoid duplications in Cygnus dts
> files
> 

We generally recommend keeping them separate:

> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index e1ac07a..30903ba 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -40,6 +40,10 @@
>         model = "Broadcom Cygnus SoC";
>         interrupt-parent = <&gic>;
>  
> +       aliases {
> +               serial0 = &uart3;
> +       };
> +

The SoC has at least four uarts according to this, so it seems unlikely that
each board really only uses only the fourth one of them and labels it '0'
on the board. As soon as you get one board that has more than one uart wired
up, you would need to undo this.

	Arnd