From: dimitri.gorokhovik@free.fr
To: David Woodhouse <dwmw2@infradead.org>,
David Woodhouse <David.Woodhouse@intel.com>,
Tim Gardner <tim.gardner@canonical.com>,
Scott James Remnant <scott@canonical.com>,
Julia Lawall <julia@diku.dk>,
David Brownell <dbrownell@users.sourceforge.net>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] nftl: write support is broken
Date: Tue, 18 Aug 2009 23:10:14 +0200 (CEST) [thread overview]
Message-ID: <25767218.3393441250629814335.JavaMail.root@zimbra3-e1.priv.proxad.net> (raw)
In-Reply-To: <1996041455.3392751250629417929.JavaMail.root@zimbra3-e1.priv.proxad.net>
Write support is broken in NFTL. Fix it.
Signed-off-by: <dimitri.gorokhovik@free.fr>
---
diff --git a/drivers/mtd/nftlcore.c b/drivers/mtd/nftlcore.c
index fb86cac..665d3eb 100644
--- a/drivers/mtd/nftlcore.c
+++ b/drivers/mtd/nftlcore.c
@@ -181,7 +181,7 @@ static int nftl_write(struct mtd_info *mtd, loff_t offs, size_t len,
int res;
ops.mode = MTD_OOB_PLACE;
- ops.ooboffs = offs;
+ ops.ooboffs = offs & (mtd->writesize - 1);
ops.ooblen = mtd->oobsize;
ops.oobbuf = oob;
ops.datbuf = buf;
parent reply other threads:[~2009-08-18 21:11 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1996041455.3392751250629417929.JavaMail.root@zimbra3-e1.priv.proxad.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25767218.3393441250629814335.JavaMail.root@zimbra3-e1.priv.proxad.net \
--to=dimitri.gorokhovik@free.fr \
--cc=David.Woodhouse@intel.com \
--cc=dbrownell@users.sourceforge.net \
--cc=dwmw2@infradead.org \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=scott@canonical.com \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®