From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754420AbdKMSa6 (ORCPT ); Mon, 13 Nov 2017 13:30:58 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:29489 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824AbdKMSa4 (ORCPT ); Mon, 13 Nov 2017 13:30:56 -0500 Subject: Re: [PATCH] mm: show stats for non-default hugepage sizes in /proc/meminfo To: Dave Hansen , Roman Gushchin Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Johannes Weiner , "Aneesh Kumar K.V" , Andrea Arcangeli , kernel-team@fb.com, linux-kernel@vger.kernel.org References: <20171113160302.14409-1-guro@fb.com> <8aa63aee-cbbb-7516-30cf-15fcf925060b@intel.com> <20171113181105.GA27034@castle> From: Mike Kravetz Message-ID: <2579a26d-81d1-732e-ef57-33bb4c293cd6@oracle.com> Date: Mon, 13 Nov 2017 10:30:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/2017 10:17 AM, Dave Hansen wrote: > On 11/13/2017 10:11 AM, Roman Gushchin wrote: >> On Mon, Nov 13, 2017 at 09:06:32AM -0800, Dave Hansen wrote: >>> On 11/13/2017 08:03 AM, Roman Gushchin wrote: >>>> To solve this problem, let's display stats for all hugepage sizes. >>>> To provide the backward compatibility let's save the existing format >>>> for the default size, and add a prefix (e.g. 1G_) for non-default sizes. >>> >>> Is there something keeping you from using the sysfs version of this >>> information? >> >> Just answered the same question to Michal. >> >> In two words: it would be nice to have a high-level overview of >> memory usage in the system in /proc/meminfo. > > I don't think it's worth cluttering up meminfo for this, imnho. I tend to agree that it would be better not to add additional huge page sizes here. It may not seem too intrusive to (potentially) add one extra set of entries for GB huge pages on x86. However, other architectures such as powerpc or sparc have several several huge pages sizes that could potentially be added here as well. Although, in practice one does tend to use a single huge pages size. If you change the default huge page size, then those entries will be in /proc/meminfo. -- Mike Kravetz