From: Jens Axboe <axboe@kernel.dk>
To: Yu Kuai <yukuai3@huawei.com>,
paolo.valente@linaro.org, jack@suse.cz, tj@kernel.org
Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org,
yi.zhang@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] block, bfq: minor cleanup and fix
Date: Fri, 28 Jan 2022 12:27:49 -0700 [thread overview]
Message-ID: <2579c500-549f-ff04-d1e1-6cf3db10b428@kernel.dk> (raw)
In-Reply-To: <164338111974.263985.3933987922467783334.b4-ty@kernel.dk>
On 1/28/22 7:45 AM, Jens Axboe wrote:
> On Fri, 31 Dec 2021 11:23:51 +0800, Yu Kuai wrote:
>> Chagnes in v2:
>> - add comment in patch 2
>> - remove patch 4, since the problem do not exist.
>>
>> Yu Kuai (3):
>> block, bfq: cleanup bfq_bfqq_to_bfqg()
>> block, bfq: avoid moving bfqq to it's parent bfqg
>> block, bfq: don't move oom_bfqq
>>
>> [...]
>
> Applied, thanks!
>
> [1/3] block, bfq: cleanup bfq_bfqq_to_bfqg()
> commit: a9c77f6ec0b566439182a10b64dd3e60a0408849
> [2/3] block, bfq: avoid moving bfqq to it's parent bfqg
> commit: 36ad7fe0ec7485ee435f7a40452c7a58598779d4
> [3/3] block, bfq: don't move oom_bfqq
> commit: a0b98e6fba18a40aa9672cc3e0abf980456f3ae6
For all those pings, this patchset sure didn't see a lot of compiles:
block/bfq-cgroup.c: In function ‘bfq_bfqq_move’:
block/bfq-cgroup.c:648:40: error: implicit declaration of function ‘bfq_group’; did you mean ‘bfqq_group’? [-Werror=implicit-function-declaration]
648 | struct bfq_group *old_parent = bfq_group(bfqq);
| ^~~~~~~~~
| bfqq_group
block/bfq-cgroup.c:648:40: error: initialization of ‘struct bfq_group *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
cc1: all warnings being treated as errors
make[1]: *** [scripts/Makefile.build:288: block/bfq-cgroup.o] Error 1
make: *** [Makefile:1831: block] Error 2
Dropped.
--
Jens Axboe
next prev parent reply other threads:[~2022-01-28 19:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 3:23 Yu Kuai
2021-12-31 3:23 ` [PATCH v2 1/3] block, bfq: cleanup bfq_bfqq_to_bfqg() Yu Kuai
2021-12-31 3:23 ` [PATCH v2 2/3] block, bfq: avoid moving bfqq to it's parent bfqg Yu Kuai
2021-12-31 3:23 ` [PATCH v2 3/3] block, bfq: don't move oom_bfqq Yu Kuai
2022-01-11 1:40 ` [PATCH v2 0/3] block, bfq: minor cleanup and fix yukuai (C)
2022-01-14 8:23 ` yukuai (C)
2022-01-14 9:59 ` Jan Kara
2022-01-18 17:53 ` Paolo Valente
2022-01-24 3:46 ` yukuai (C)
2022-01-28 9:35 ` yukuai (C)
2022-01-28 14:45 ` Jens Axboe
2022-01-28 19:27 ` Jens Axboe [this message]
2022-01-29 1:42 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2579c500-549f-ff04-d1e1-6cf3db10b428@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome