From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] x86/kvm: Remove defunct KVM_DEBUG_FS Kconfig
Date: Thu, 28 May 2020 13:56:26 +0200 [thread overview]
Message-ID: <257b0ba7-84e2-89de-3708-1174f5d090be@redhat.com> (raw)
In-Reply-To: <20200528031121.28904-1-sean.j.christopherson@intel.com>
On 28/05/20 05:11, Sean Christopherson wrote:
> Remove KVM_DEBUG_FS, which can easily be misconstrued as controlling
> KVM-as-a-host. The sole user of CONFIG_KVM_DEBUG_FS was removed by
> commit cfd8983f03c7b ("x86, locking/spinlocks: Remove ticket (spin)lock
> implementation").
>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
> arch/x86/Kconfig | 8 --------
> arch/x86/kernel/kvm.c | 1 -
> 2 files changed, 9 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 1197b5596d5ad..0ccf4e76acfe8 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -818,14 +818,6 @@ config PVH
> This option enables the PVH entry point for guest virtual machines
> as specified in the x86/HVM direct boot ABI.
>
> -config KVM_DEBUG_FS
> - bool "Enable debug information for KVM Guests in debugfs"
> - depends on KVM_GUEST && DEBUG_FS
> - ---help---
> - This option enables collection of various statistics for KVM guest.
> - Statistics are displayed in debugfs filesystem. Enabling this option
> - may incur significant overhead.
> -
> config PARAVIRT_TIME_ACCOUNTING
> bool "Paravirtual steal time accounting"
> depends on PARAVIRT
> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index 6efe0410fb728..89ba09228eaf5 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -21,7 +21,6 @@
> #include <linux/sched.h>
> #include <linux/slab.h>
> #include <linux/kprobes.h>
> -#include <linux/debugfs.h>
> #include <linux/nmi.h>
> #include <linux/swait.h>
> #include <asm/timer.h>
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2020-05-28 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 3:11 Sean Christopherson
2020-05-28 11:56 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=257b0ba7-84e2-89de-3708-1174f5d090be@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®