From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753547AbdGLQbf (ORCPT ); Wed, 12 Jul 2017 12:31:35 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:47463 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752982AbdGLQbd (ORCPT ); Wed, 12 Jul 2017 12:31:33 -0400 X-AuditID: b6c32a2c-f79e76d00000129c-ba-59664ee193c3 From: Bartlomiej Zolnierkiewicz To: Arnd Bergmann Cc: "Gustavo A. R. Silva" , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] atyfb: hide unused variable Date: Wed, 12 Jul 2017 18:31:21 +0200 Message-id: <2581869.RWDtV5qma6@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170710111312.747154-1-arnd@arndb.de> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJIsWRmVeSWpSXmKPExsWy7bCmhu5Dv7RIg/Xn9Cz+TjrGbrFyyX42 ixN9H1gtLu+aw+bA4vH71yRGj3UHVT0+b5ILYI7isklJzcksSy3St0vgymg89ZO1YDNrxa2e k8wNjEdYuhg5OSQETCQWbP/MBGGLSVy4t56ti5GLQ0hgKaPE+42XmCGcz4wSB/e8YoPpaJyy jB0isQMosfEIVMtXRolJP26yg1SxCVhJTGxfxQhiiwgoSkx98YwZxGYWKJA4eGgeK4gtLGAg cfzoNrCpLAKqEocuLQHr5RXQlDh45wBYr6iAl8SWfe1g93ECbX6y+DoLRI2gxI/J91ggZspL 7Ns/lRXC1pE4e2wdI8hBEgKv2SS2PWsCWswB5MhKbDrADPGBi0TD5/VQtrDEq+Nb2CFsKYnu jllQ9nRGie2/JSDmbGaUWLV7AlTCWuLw8YtQy/gken8/YYKYzyvR0SYEYXpIbFxRAFHtKDH5 VC80fNqB4fP9BPsERvlZSF6YheSFWUheWMDIvIpRLLWgODc9tdi0wFCvODG3uDQvXS85P3cT IzhBaOnsYLy3wPsQowAHoxIPL4dmWqQQa2JZcWXuIUYJDmYlEd6jPkAh3pTEyqrUovz4otKc 1OJDjNIcLErivBorr0UICaQnlqRmp6YWpBbBZJk4OKUaGMOOuOaFvlTYPt/T7dTkDbOuMJq+ Z2ksW2FbyfN4XirzoYf5bz4eEPB50Jd2fDJL1hnfHwH3/806VBsUtvWE6Xw1/bgpWhfnZFQW fNSaKjgluGCFVdzutP81u2/Kva2uSX0ddGz/bGWXtJYwJo7FJzn+8W5KquT/fNcwTLkze290 6NKD6qzOb5VYijMSDbWYi4oTAXUX0roMAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42I5/e+xgO4Dv7RIgwsfdS3+TjrGbrFyyX42 ixN9H1gtLu+aw+bA4vH71yRGj3UHVT0+b5ILYI5ys8lITUxJLVJIzUvOT8nMS7dVCg1x07VQ UshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW0bjqZ+sBZtZK271nGRuYDzC0sXI ySEhYCLROGUZO4QtJnHh3nq2LkYuDiGBbYwSO182MUE4XxklTn++wQhSxSZgJTGxfRWYLSKg KDH1xTNmEJtZoEDifeMSJhBbWMBA4vjRbWwgNouAqsShS0vANvAKaEocvHMArFdUwEtiy752 sHpOoCueLL7OArGsk1HizKrjrBANghI/Jt9jgVggL7Fv/1RWCFtLYv3O40wTGAVmISmbhaRs FpKyBYzMqxi5UguKc9Nzi40KjDYxAuNi22GtgB2MTeeiDzEKcDAq8fBuUEuLFGJNLCuuzD3E KMHBrCTCe9QHKMSbklhZlVqUH19UmpNafIjRFOinicxSosn5wJjNK4k3NLE0MjEwMzM0MjA2 UxLnnRD4JUJIID2xJDU7NbUgtQimj4mDU6qBceeK05s3/k4J2tq6T0TxW/4nbkHjG8/uX7rQ cO592KHTk37pNv0UTZWfWuaySMBg2YWHUb0Mq5+5e6r8PPA9Lq7G4nt7l2oed5qlhDT/YaPf NQV+InvFtI/w7H38srwov6jpRdfFrq9en9P8P4t//tut++WazEMH+1fvtKeti1bKtXpgqt6c rsRSnJFoqMVcVJwIAFUxq3ahAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170712163128epcas5p2bf81492ef182701b7fd49dfceb19fa7c X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-CMS-RootMailID: 20170710111335epcas4p38f91ea2aa1c12161af113766b989e8f1 X-RootMTR: 20170710111335epcas4p38f91ea2aa1c12161af113766b989e8f1 References: <20170710111312.747154-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, July 10, 2017 01:12:46 PM Arnd Bergmann wrote: > The vdisplay variable is now only accessed inside of an #ifdef, producing > a harmless warning: > > drivers/video/fbdev/aty/atyfb_base.c: In function 'aty_var_to_crtc': > drivers/video/fbdev/aty/atyfb_base.c:805:19: error: unused variable 'vdisplay' [-Werror=unused-variable] > > This moves the declaration into the ifdef as well. > > Fixes: dd7d958ae912 ("video: fbdev: aty: remove useless variable assignments in aty_var_to_crtc()") > Signed-off-by: Arnd Bergmann Patch queued for 4.13, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics