mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Chen Ni <nichen@iscas.ac.cn>,
	perex@perex.cz, tiwai@suse.com, franta-linux@frantovo.cz,
	lina+kernel@asahilina.net, livvy@base.nu, sstistrup@gmail.com,
	s@srd.tw
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon
Date: Thu, 12 Jun 2025 09:13:59 +0300	[thread overview]
Message-ID: <25839448-6307-479d-a6f2-8c3ae03bbfaf@collabora.com> (raw)
In-Reply-To: <20250612060228.1518028-1-nichen@iscas.ac.cn>

On 6/12/25 9:02 AM, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  sound/usb/mixer_quirks.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
> index 0769ecd91144..a0ffe8b559dc 100644
> --- a/sound/usb/mixer_quirks.c
> +++ b/sound/usb/mixer_quirks.c
> @@ -762,9 +762,9 @@ static int snd_dualsense_jack_create(struct usb_mixer_interface *mixer,
>  
>  	mei->ih.event = snd_dualsense_ih_event;
>  	mei->ih.match = snd_dualsense_ih_match;
> -	mei->ih.connect = snd_dualsense_ih_connect,
> -	mei->ih.disconnect = snd_dualsense_ih_disconnect,
> -	mei->ih.start = snd_dualsense_ih_start,
> +	mei->ih.connect = snd_dualsense_ih_connect;
> +	mei->ih.disconnect = snd_dualsense_ih_disconnect;
> +	mei->ih.start = snd_dualsense_ih_start;
>  	mei->ih.name = name;
>  	mei->ih.id_table = mei->id_table;


Thanks for catching this!

Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>


  reply	other threads:[~2025-06-12  6:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12  6:02 Chen Ni
2025-06-12  6:13 ` Cristian Ciocaltea [this message]
2025-06-12  6:52 ` Takashi Iwai
2025-06-12  7:22   ` Cristian Ciocaltea
2025-06-12  7:30     ` Takashi Iwai
2025-06-12  7:48       ` Cristian Ciocaltea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25839448-6307-479d-a6f2-8c3ae03bbfaf@collabora.com \
    --to=cristian.ciocaltea@collabora.com \
    --cc=franta-linux@frantovo.cz \
    --cc=lina+kernel@asahilina.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=livvy@base.nu \
    --cc=nichen@iscas.ac.cn \
    --cc=perex@perex.cz \
    --cc=s@srd.tw \
    --cc=sstistrup@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®