From: Keith Owens <kaos@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: oleg@tv-sign.ru, ebiederm@xmission.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 2.6.17-rc1] Reinstate const in next_thread()
Date: Mon, 03 Apr 2006 18:40:29 +1000 [thread overview]
Message-ID: <25841.1144053629@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Mon, 03 Apr 2006 01:33:42 MST." <20060403013342.5e34c3ba.akpm@osdl.org>
Andrew Morton (on Mon, 3 Apr 2006 01:33:42 -0700) wrote:
>Keith Owens <kaos@sgi.com> wrote:
>>
>> Before commit 47e65328a7b1cdfc4e3102e50d60faf94ebba7d3, next_thread()
>> took a const task_t. Reinstate the const qualifier, getting the next
>> thread never changes the current thread.
>>
>
>Can do, but why? Does code generation improve?
I have not checked. The const qualifier on this type of function falls
into the "better safe than sorry" category.
prev parent reply other threads:[~2006-04-03 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-03 8:25 Keith Owens
2006-04-03 8:33 ` Andrew Morton
2006-04-03 8:40 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25841.1144053629@kao2.melbourne.sgi.com \
--to=kaos@sgi.com \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome