From: wlf <wulf@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>, William Wu <william.wu@rock-chips.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
frank.wang@rock-chips.com, huangtao@rock-chips.com,
daniel.meng@rock-chips.com
Subject: Re: [PATCH 1/2] ARM: dts: rockchip: add usb nodes on rk322x
Date: Fri, 2 Jun 2017 09:44:51 +0800 [thread overview]
Message-ID: <2584cf1a-7ffb-b5ba-3324-fca3f4fd402e@rock-chips.com> (raw)
In-Reply-To: <1657625.AqxPQItbmB@phil>
Dear Heiko,
在 2017年06月02日 04:22, Heiko Stuebner 写道:
> Hi William,
>
> Am Mittwoch, 31. Mai 2017, 09:21:23 CEST schrieb William Wu:
>> This patch adds usb otg/host controllers and phys nodes on rk322x.
>>
>> Signed-off-by: William Wu <william.wu@rock-chips.com>
>> ---
>> arch/arm/boot/dts/rk322x.dtsi | 138 +++++++++++++++++++++++++++++++++++++++++-
>> 1 file changed, 137 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
>> index df57413..d4bfd3c 100644
>> --- a/arch/arm/boot/dts/rk322x.dtsi
>> +++ b/arch/arm/boot/dts/rk322x.dtsi
>> @@ -210,8 +210,61 @@
>> };
>>
>> grf: syscon@11000000 {
>> - compatible = "syscon";
>> + compatible = "syscon", "simple-mfd";
>> reg = <0x11000000 0x1000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + u2phy0: usb2-phy@760 {
>> + compatible = "rockchip,rk322x-usb2phy";
> as commented on the driver-side some moments ago, compatibles should not
> contain wildcards, so please make this
> "rockchip,rk3228-usb2phy"
> instead.
>
> Same below and also for the dwc2 node.
Thanks, I'll fix it immediately.
>
>
> Thanks
> Heiko
>
>> + reg = <0x0760 0x0c>;
>> + clocks = <&cru SCLK_OTGPHY0>;
>> + clock-names = "phyclk";
>> + #clock-cells = <0>;
>> + clock-output-names = "usb480m_phy0";
>> + status = "disabled";
>> +
>> + u2phy0_otg: otg-port {
>> + #phy-cells = <0>;
>> + interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "otg-bvalid", "otg-id",
>> + "linestate";
>> + status = "disabled";
>> + };
>> +
>> + u2phy0_host: host-port {
>> + #phy-cells = <0>;
>> + interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "linestate";
>> + status = "disabled";
>> + };
>> + };
>> +
>> + u2phy1: usb2-phy@800 {
>> + compatible = "rockchip,rk322x-usb2phy";
> rockchip,rk3228-usb2phy
OK, I'll fix it immediately.
>
>> + reg = <0x0800 0x0c>;
>> + clocks = <&cru SCLK_OTGPHY1>;
>> + clock-names = "phyclk";
>> + #clock-cells = <0>;
>> + clock-output-names = "usb480m_phy1";
>> + status = "disabled";
>> +
>> + u2phy1_otg: otg-port {
>> + #phy-cells = <0>;
>> + interrupts = <GIC_SPI 68 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "linestate";
>> + status = "disabled";
>> + };
>> +
>> + u2phy1_host: host-port {
>> + #phy-cells = <0>;
>> + interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "linestate";
>> + status = "disabled";
>> + };
>> + };
>> };
>>
>> uart0: serial@11010000 {
>> @@ -467,6 +520,89 @@
>> status = "disabled";
>> };
>>
>> + usb_otg: usb@30040000 {
>> + compatible = "rockchip,rk322x-usb", "rockchip,rk3066-usb",
> rockchip,rk3228-usb
OK, I'll fix it immediately.:-)
>
>> + "snps,dwc2";
>> + reg = <0x30040000 0x40000>;
>> + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru HCLK_OTG>;
>> + clock-names = "otg";
>> + dr_mode = "otg";
>> + g-np-tx-fifo-size = <16>;
>> + g-rx-fifo-size = <280>;
>> + g-tx-fifo-size = <256 128 128 64 32 16>;
>> + g-use-dma;
>> + phys = <&u2phy0_otg>;
>> + phy-names = "usb2-phy";
>> + status = "disabled";
>> + };
>> +
>> + usb_host0_ehci: usb@30080000 {
>> + compatible = "generic-ehci";
>> + reg = <0x30080000 0x20000>;
>> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru HCLK_HOST0>, <&u2phy0>;
>> + clock-names = "usbhost", "utmi";
>> + phys = <&u2phy0_host>;
>> + phy-names = "usb";
>> + status = "disabled";
>> + };
>> +
>> + usb_host0_ohci: usb@300a0000 {
>> + compatible = "generic-ohci";
>> + reg = <0x300a0000 0x20000>;
>> + interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru HCLK_HOST0>, <&u2phy0>;
>> + clock-names = "usbhost", "utmi";
>> + phys = <&u2phy0_host>;
>> + phy-names = "usb";
>> + status = "disabled";
>> + };
>> +
>> + usb_host1_ehci: usb@300c0000 {
>> + compatible = "generic-ehci";
>> + reg = <0x300c0000 0x20000>;
>> + interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru HCLK_HOST1>, <&u2phy1>;
>> + clock-names = "usbhost", "utmi";
>> + phys = <&u2phy1_otg>;
>> + phy-names = "usb";
>> + status = "disabled";
>> + };
>> +
>> + usb_host1_ohci: usb@300e0000 {
>> + compatible = "generic-ohci";
>> + reg = <0x300e0000 0x20000>;
>> + interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru HCLK_HOST1>, <&u2phy1>;
>> + clock-names = "usbhost", "utmi";
>> + phys = <&u2phy1_otg>;
>> + phy-names = "usb";
>> + status = "disabled";
>> + };
>> +
>> + usb_host2_ehci: usb@30100000 {
>> + compatible = "generic-ehci";
>> + reg = <0x30100000 0x20000>;
>> + interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru HCLK_HOST2>, <&u2phy1>;
>> + phys = <&u2phy1_host>;
>> + phy-names = "usb";
>> + clock-names = "usbhost", "utmi";
>> + status = "disabled";
>> + };
>> +
>> + usb_host2_ohci: usb@30120000 {
>> + compatible = "generic-ohci";
>> + reg = <0x30120000 0x20000>;
>> + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru HCLK_HOST2>, <&u2phy1>;
>> + clock-names = "usbhost", "utmi";
>> + phys = <&u2phy1_host>;
>> + phy-names = "usb";
>> + status = "disabled";
>> + };
>> +
>> gmac: ethernet@30200000 {
>> compatible = "rockchip,rk3228-gmac";
>> reg = <0x30200000 0x10000>;
>>
>
>
>
>
next prev parent reply other threads:[~2017-06-02 1:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 1:21 [PATCH 0/2] Add usb nodes on rk322x SoCs and enable usb on rk3229 evb William Wu
2017-05-31 1:21 ` [PATCH 1/2] ARM: dts: rockchip: add usb nodes on rk322x William Wu
2017-06-01 20:22 ` Heiko Stuebner
2017-06-02 1:44 ` wlf [this message]
2017-05-31 1:21 ` [PATCH 2/2] ARM: dts: rockchip: enable usb for rk3229 evb board William Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2584cf1a-7ffb-b5ba-3324-fca3f4fd402e@rock-chips.com \
--to=wulf@rock-chips.com \
--cc=daniel.meng@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=frank.wang@rock-chips.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=william.wu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®