From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DF5D8488 for ; Wed, 18 Dec 2024 00:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734480206; cv=none; b=APWr46dTVLka6uy3bWn9Wlw50uH32t2NGkr8QlTybVp464/uFYEcnqSIQm5X0jzC9vidt5FgQw+31smox+r1uU+WkEbbzUxmTavIehbeRYmMQ/o0poE1lsrT/rRyQydHiKxI/p40z8r6rRHFpO/1gSSvOfWvDrQtli1M7m9T3zA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734480206; c=relaxed/simple; bh=NSMSQX69n+ZOWKOumU9eGjQjw6XAhiIIhUWYBTncc18=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=nZWu8NNyFdVM4DI3ehI48JW9vU40vExIMOMh/I14ZUQpaEQzt6vkEcaeAreO1xZe04hAN17gDU0SiyAbAptS0eeBV4y1oNIjNE70HNJ5BMuNlOWVdDe2LdUw96DAhPcxlpFLa1z1IwMDgWh8c4GKNj7xqvwH2itytJY5Iot50TI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hvYFXvFf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hvYFXvFf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734480204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VvmJ+CqaqeToMgMuDFmCeT3MDz3+kzBsmlyYC/rHsN0=; b=hvYFXvFf9Sk99zVWqLJcdDWlxHmZs4AQYBYz+F4lt3Vee2go3+UxiHHXUvIBxLTUCdXhHp KaLaIJ1VXrHFfT0tvkZO/u0dWPYXhunxr1XIpg2QGJ5YJCpi4gTIGg10JAwNaYCgWl0D0s j0Uhjca90vki0BMY5aui76ZoVlitpKE= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-cyA3EaLAOwydzRGwvZ9giA-1; Tue, 17 Dec 2024 19:03:23 -0500 X-MC-Unique: cyA3EaLAOwydzRGwvZ9giA-1 X-Mimecast-MFC-AGG-ID: cyA3EaLAOwydzRGwvZ9giA Received: by mail-io1-f71.google.com with SMTP id ca18e2360f4ac-844e6476afeso416919339f.0 for ; Tue, 17 Dec 2024 16:03:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734480200; x=1735085000; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VvmJ+CqaqeToMgMuDFmCeT3MDz3+kzBsmlyYC/rHsN0=; b=ltgePXF20hBGxaiWoMssQtxfi19MlJg7A8RXh2liHGRCswtzfv88I/5k4D7B9RsFm6 Bqp7JjP9OLEM/TRVtLnfPDrLSL545I7hZfY3u0WGFSGesrbgMl3m/77iS/un2EHI5yBU V6OVpG1mlbmCm6mI87KbWml6yziAMlM1jNglqP3Z4RDxGGmdSLMGCct2J0Qm8KbVhNL9 rU0X30mBV/fVjhSTPphCwpedCqbDLPt0sKDkQXV7kBTeYXst6FZ3kq/uwtxAKMswfYap kpYYeSTLJUuLiCBZvrTti1stA4Xl8REo7fxsJArJX/pMcSgk4GW3tonYAUfSsTvcwIDm v6UQ== X-Forwarded-Encrypted: i=1; AJvYcCW9sl0iGhzccPZb0n8u/QBcLh9OZc7ReP4XavObAR7fHiDOH1NxagLuIwr6lNygi//mOVboNwIOcRcgM9Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzHAFkzS0HMtKMC/RXon6xWAIxitExSQUb4tN8+H4c0rtP4RKSy 8cftbqxTyPHIVk+x5B9afT/q4ccGkyUrFj1zg3sukcttIyR6zfCf20saWAAvcNOl5ehQRhDaZIb K9AaH3QwLolAxUCecyQuNAmNGcmTmYC9qIqtsLM4cSMsaz3Dqhfe87F712o12wdfsjLgiXg== X-Gm-Gg: ASbGncsXoI2X00rpn+bQWH3yDpjnFx+zAyViO4Re7CeE35lU8aNgPLQSOWmnjv2LJ2n azmcElEtLz3OhGXzLu6z3wpSORI1uBDqXK/sIhS8AZ8Ah1qxQ+u1XLKBYFAUZoQLYRvd3KkJCMM CpTaZzn3N+iASUWFTHUFpQZAkRZFmk2gFWzOiDwPaOsYP/OPWDtVj80N0Pjhg8s0Q+U5ZNCw3pe +YoTNa5eqSVbqQ3zaudzZi1htcFLrrvNVU6OZy1N0aDQ01wus5XikFW X-Received: by 2002:a05:6602:14d0:b0:835:4b2a:e52b with SMTP id ca18e2360f4ac-847585d72bemr82149339f.10.1734480200463; Tue, 17 Dec 2024 16:03:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfpU/btENnVM27N0VJ4nHbdYuAaCJ/rQA4svcBFZjOZUVMhayktZikmu2cS2T/Nonrx/K5Kw== X-Received: by 2002:a05:6602:14d0:b0:835:4b2a:e52b with SMTP id ca18e2360f4ac-847585d72bemr82147539f.10.1734480200147; Tue, 17 Dec 2024 16:03:20 -0800 (PST) Received: from starship ([2607:fea8:fc01:8d8d:6adb:55ff:feaa:b156]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e5e3b754d9sm1941942173.144.2024.12.17.16.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 16:03:19 -0800 (PST) Message-ID: <2587c4e8d912b461e793155e7749d0e03067b0d6.camel@redhat.com> Subject: Re: [PATCH 20/20] KVM: selftests: Allow running a single iteration of dirty_log_test From: Maxim Levitsky To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Xu Date: Tue, 17 Dec 2024 19:03:18 -0500 In-Reply-To: <20241214010721.2356923-21-seanjc@google.com> References: <20241214010721.2356923-1-seanjc@google.com> <20241214010721.2356923-21-seanjc@google.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit On Fri, 2024-12-13 at 17:07 -0800, Sean Christopherson wrote: > Now that dirty_log_test doesn't require running multiple iterations to > verify dirty pages, and actually runs the requested number of iterations, > drop the requirement that the test run at least "3" (which was really "2" > at the time the test was written) iterations. > > Opportunistically use atoi_positive() to do the heavy lifting. > > Signed-off-by: Sean Christopherson > --- > tools/testing/selftests/kvm/dirty_log_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/dirty_log_test.c b/tools/testing/selftests/kvm/dirty_log_test.c > index ccc5d9800bbf..05b06476bea4 100644 > --- a/tools/testing/selftests/kvm/dirty_log_test.c > +++ b/tools/testing/selftests/kvm/dirty_log_test.c > @@ -880,7 +880,7 @@ int main(int argc, char *argv[]) > } > } > > - TEST_ASSERT(p.iterations > 2, "Iterations must be greater than two"); > + TEST_ASSERT(p.iterations > 0, "Iterations must be greater than two"); You didn't update the assert message. > TEST_ASSERT(p.interval > 0, "Interval must be greater than zero"); > > pr_info("Test iterations: %"PRIu64", interval: %"PRIu64" (ms)\n",