From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ASoC: Intel: Skylake: Avoid the use of one-element array
Date: Mon, 20 Jul 2020 11:11:49 +0200 [thread overview]
Message-ID: <25892fe8-2ec4-9105-851b-8a0520756057@linux.intel.com> (raw)
In-Reply-To: <20200717215500.GA13910@embeddedor>
Looks ok and tests on our side also pass.
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
On 7/17/2020 11:55 PM, Gustavo A. R. Silva wrote:
> One-element arrays are being deprecated[1]. Replace the one-element
> array with a simple value type 'u8 reserved'[2], once it seems this
> is just a placeholder for alignment.
>
> [1] https://github.com/KSPP/linux/issues/79
> [2] https://github.com/KSPP/linux/issues/86
>
> Tested-by: kernel test robot <lkp@intel.com>
> Link: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/skylake-20200717.md
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> sound/soc/intel/skylake/skl-topology.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/skylake/skl-topology.h b/sound/soc/intel/skylake/skl-topology.h
> index 9889f728752c..5e93ad85e06d 100644
> --- a/sound/soc/intel/skylake/skl-topology.h
> +++ b/sound/soc/intel/skylake/skl-topology.h
> @@ -97,7 +97,7 @@ struct skl_audio_data_format {
> u8 number_of_channels;
> u8 valid_bit_depth;
> u8 sample_type;
> - u8 reserved[1];
> + u8 reserved;
> } __packed;
>
> struct skl_base_cfg {
>
next prev parent reply other threads:[~2020-07-20 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 21:55 Gustavo A. R. Silva
2020-07-20 9:11 ` Amadeusz Sławiński [this message]
2020-07-20 14:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25892fe8-2ec4-9105-851b-8a0520756057@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=gustavoars@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®