From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2126433554F for ; Wed, 15 Apr 2026 04:08:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776226118; cv=none; b=ZqlVjHIml+CrtNvA1LxYNd5OLbmRWl9fVh9GQgCgbdYA3EAoFZcdXPeHP/yz5CCUnOEdksHRfV2qwsPKdA+2Gt85+evEsuSaoQxa7IaD4G45PfuRWqhamSg2l0isit/eIkw0etSFHtfZ+ncvQjoBhrV5fj2J8V155duGmKplv1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776226118; c=relaxed/simple; bh=1JFYliA1eIfO38BDolH5vZE2GQiymOSm1FE48m3IXyM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UqyH0EHwIzsllZ5ByU7JwJfqY8bE1IMMiOW+lO4AlaaKqv2qUUqVYhPAo9NTsCWLql90uDjZTJYxgNTiOEZpAfrRBZbAS5TSfVVbDOxZSrusl8OYa69Dd/03WAaUGVbKMIN5dWnXX+RIsNkppfBz8UTw5K5Jr178I8B0o1ETcY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=vt.edu; spf=pass smtp.mailfrom=vt.edu; dkim=pass (2048-bit key) header.d=vt-edu.20251104.gappssmtp.com header.i=@vt-edu.20251104.gappssmtp.com header.b=LBrnccc6; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=vt.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vt.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vt-edu.20251104.gappssmtp.com header.i=@vt-edu.20251104.gappssmtp.com header.b="LBrnccc6" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-12c555f886dso2716408c88.0 for ; Tue, 14 Apr 2026 21:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20251104.gappssmtp.com; s=20251104; t=1776226115; x=1776830915; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ScBve9F1pkkVpbC3fWLbe3v5cogqHa2vYvsAA5m89zY=; b=LBrnccc695EiH/c8KELWCNqj/5ozgnsXEXDBs1DFPknl/SdL14fxcj+K58fGDnQupa suMNOKr6H96qnKo8d8FhyZH7XzhwnNsNeNqk+CUhGNjZ7+6paUXucCbFm52YXZNES/f7 +ikvzIi3cjdwDDYUv3DYsvX6SJQE5Ye+41c/Fovm5Bz/6RyE7re96rpWovlhqJnMGZvR ggZx8bo5bTuifVYD+5a5h1BOFpIXecD+O2SuqdUEiYXgNIvHZUxZFzi0C7orhaCmEyoW FnEjifcd26sc+2CxYqh/OQriHDiRxW6Kz0/CJYJyncDcCIodVgzY+Q1TxNUCdqzEIpRs gEEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776226115; x=1776830915; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ScBve9F1pkkVpbC3fWLbe3v5cogqHa2vYvsAA5m89zY=; b=tRnhU8Of8Q6e2DjwDQw10/DxbdJNriuM0lTKiU4WjYNCdWyNsRmnCG0S+VnDN70QjQ d1wXqqxpxkyIfTlhX0w/j9EKT9EgDi1DmDzlo2+5gZarY7pwEbM+m8NzKGMH1u+RnL+/ nfnSDT69phtQ7JsaZRzDC02lfUj0Dlw4ESsgK5NJEjWDU9lPNXclTU6Fi1j2uOz1PGUL SPDMGYVO8IkwdokRIPMUt1S4X1BOH6YUabqQFVKRTRYK7dy0YcQF/thdKMvhV31VJhUl YvlTJTBlWP50DkDSuy8WlpELWMRUx2XOrANACDh5puklF7C7LvVoQO5o4HUeEn3wJOGT ZI2g== X-Forwarded-Encrypted: i=1; AFNElJ9oHvICxWv6hHanoEtgZRK5NHF23ZbnZlHydpJhwJRrb1RzDWFNSqqEnfVR2hOCe2WiFIoY2GPUmBqxpkM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2III45jGjgBFs3Y7SZUuWhDBuwd/OGPQNiYoI5TSZeuUfROi5 CyprnDWBN+atYeTYxMRsqRuliGvTQcwzFAf3NIBQfomVrA+odpT34mlp8sZT+Rj5H70= X-Gm-Gg: AeBDieu2NFqaA00c8jr+27Emw1cRfV2RiRj1ArsRTdfkFtZMHaegBGKj02chVziQsFD Ag0HGlCRS0ZRDl0g3isELwozPvZi1rjO8oPsEIq7FybQAS0oNQikcKdBxIEcWdloRKRuPOxkFYB 2y1wayGyNflkY2SUOWeygEt4fBllIvAAOoYnprPFWjK2vhNUsB5W16Kch7NS71VsN6XUKfC11fp M5zk4dlbMcDOa3XMfZV4jC49KGyCMc25qBn8p24uslzTVeLKRoBD3GIqtj/NrNMpcTOdZeUjLrQ sCGu+JlznfrzDS5rQu/GM6DnGiD7vWXIp34U59FepdEF5LQKdHc9vkkXVCW6mQOJTtJ/LIuz3iA BGKo5/N13UzAnImy3TvQC2N3dsfeJUU/aDMRwIetnIsTKt567GYqXb1jV1Ww5x80ZVPZa2inbQE NERE7D1D7/TYJDZ/UAWd8pVbkmm8R7ku9Ck1zSIGf39zeihgEPnsoTWzWJbOeubfrTGvMk2kNk9 xkGzJ9fC+q+ZGqjz3D77XKFLiL/cuH9IidNiec/ X-Received: by 2002:a05:7022:48f:b0:127:5cda:fb7d with SMTP id a92af1059eb24-12c34e4524fmr10782658c88.6.1776226114823; Tue, 14 Apr 2026 21:08:34 -0700 (PDT) Received: from [192.168.86.23] ([136.25.189.61]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c5e5827aasm637402c88.0.2026.04.14.21.08.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 21:08:34 -0700 (PDT) Message-ID: <258ab32c-4704-48a8-aec4-739c497a80d3@vt.edu> Date: Tue, 14 Apr 2026 21:08:34 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] scsi: target: iscsi: reject invalid size Extended CDB AHS To: "Martin K. Petersen" , Carlos Bilbao Cc: Dmitry Bogdanov , carlos.bilbao@kernel.org, kees@kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <20260404014429.115807-1-carlos.bilbao@kernel.org> <20260409024253.34926-1-carlos.bilbao@kernel.org> <20260409093159.GA902@yadro.com> <0657bd66-43df-43b0-97d0-16288595e229@gmail.com> Content-Language: en-US From: Carlos Bilbao In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/13/26 19:36, Martin K. Petersen wrote: > Carlos, > >>>> + u16 cdb_length = ahslength - 1 + ISCSI_CDB_SIZE; >>> AFAIK, a variable declarationis allowed to be in the beginning of code block only. >> You're absolutely right, happy to send v3 if the maintainer prefers. > Yes, please. Best to stay consistent with the existing coding style in a > given file. Sure, v3 sent! > Thanks, Carlos