From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Rob Herring <robh@kernel.org>, Andy Whitcroft <apw@canonical.com>,
Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Subject: checkpatch query regarding .c and .h files..
Date: Sun, 02 Jun 2019 13:02:44 -0400 [thread overview]
Message-ID: <25942.1559494964@turing-police> (raw)
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
scripts/checkpatch.pl contains this code near line 3070:
if ($realfile =~ /\.(h|s|S)$/) {
$comment = '/*';
} elsif ($realfile =~ /\.(c|dts|dtsi)$/) {
$comment = '//';
} elsif (($checklicenseline == 2) || $realfile =~ /\.(sh|pl|py|awk|tc)$/) {
$comment = '#';
} elsif ($realfile =~ /\.rst$/) {
$comment = '..';
}
Was there a specific reason why .h files have /* */ and .c files have C89 // on
the SPDX comment line?
Would anybody like a patch that fixed checkpatch to allow either flavor on .c and .h files?
(I know I would, I just blew close to an hour trying to figure out why it whined about a
SPDX in a .h file I'm getting ready to upstream...)
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
next reply other threads:[~2019-06-02 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 17:02 Valdis Klētnieks [this message]
2019-06-02 18:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25942.1559494964@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®