From: Andrew Lunn <andrew@lunn.ch>
To: Ingo van Lil <inguin@gmx.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Dan Murphy <dmurphy@ti.com>,
Alexander Sverdlin <alexander.sverdlin@siemens.com>
Subject: Re: [PATCH net] net: phy: dp83869: fix memory corruption when enabling fiber
Date: Wed, 2 Oct 2024 19:01:19 +0200 [thread overview]
Message-ID: <2595456f-c55a-4de6-be2d-8d544f453b18@lunn.ch> (raw)
In-Reply-To: <20241002161807.440378-1-inguin@gmx.de>
On Wed, Oct 02, 2024 at 06:18:07PM +0200, Ingo van Lil wrote:
> When configuring the fiber port, the DP83869 PHY driver incorrectly
> calls linkmode_set_bit() with a bit mask (1 << 10) rather than a bit
> number (10). This corrupts some other memory location -- in case of
> arm64 the priv pointer in the same structure.
>
> Since the advertising flags are updated from supported at the end of the
> function the incorrect line isn't needed at all and can be removed.
>
> Fixes: a29de52ba2a1 ("net: dp83869: Add ability to advertise Fiber connection")
> Signed-off-by: Ingo van Lil <inguin@gmx.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2024-10-02 17:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 16:18 Ingo van Lil
2024-10-02 16:47 ` Sverdlin, Alexander
2024-10-02 17:01 ` Andrew Lunn [this message]
2024-10-04 18:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2595456f-c55a-4de6-be2d-8d544f453b18@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexander.sverdlin@siemens.com \
--cc=dmurphy@ti.com \
--cc=inguin@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®