From: "Martin J. Bligh" <mbligh@mbligh.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, colpatch@us.ibm.com
Subject: Re: [PATCH] Fix NUMA node sizing in nr_free_zone_pages
Date: Sat, 30 Jul 2005 06:49:44 -0700 [thread overview]
Message-ID: <259590000.1122731383@[10.10.2.4]> (raw)
In-Reply-To: <20050729224043.7ce56d4e.akpm@osdl.org>
>> We are iterating over all nodes in nr_free_zone_pages(). Because the
>> fallback zonelists contain all nodes in the system, and we walk all
>> the zonelists, we're counting memory multiple times (once for each
>> node). This caused us to make a size estimate of 32GB for an 8GB
>> AMD64 box, which makes all the dirty ratio calculations, etc incorrect.
>>
>> There's still a further bug to fix from e820 holes causing overestimation
>> as well, but this fix is separate, and good as is, and fixes one class
>> of problems. Problem found by Badari, and tested by Ram Pai - thanks!
>
> Alas my non-NUMA EMT64 box still gets it wrong.
>
> nr_free_pagecache_pages() is still returning 1572864 on a 4G box.
Yeah, it will do - is the e820 bug I mentioned above. Patch is half-written,
will finish it off ASAP, but I'll be out today ;-(
M.
prev parent reply other threads:[~2005-07-30 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-29 18:31 Martin J. Bligh
2005-07-29 20:05 ` Andrew Morton
2005-07-30 5:40 ` Andrew Morton
2005-07-30 13:49 ` Martin J. Bligh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='259590000.1122731383@[10.10.2.4]' \
--to=mbligh@mbligh.org \
--cc=akpm@osdl.org \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®