From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 690703DB96B for ; Tue, 16 Jun 2026 06:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781591443; cv=none; b=dovSe4SGplcZHyexObqBa4FEIsvdgjRsgzZgmTK5LCU9zjeFMxQ0367Gm0F51SZUclA+lQIYL2SiaetysdueEefSlYCJMpPU3f0i/Fahe1eDQPb0utPwVTWHPtKmcS9gVPQ4p/kjDKMaly7xaAzsImc4GmLfoNLjTqQ89A7hX2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781591443; c=relaxed/simple; bh=d0PyyVSRbSP9Kr0Dy6OM19mxr39eIu2S6iW1opMVtVM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gB5up8kw0gGKC8AwNBWjIoKJ0GriaSnpvYQ7ck8RPjQJepImiwXHtpziv0jrApjAwUVfFltDUweOogfkZcz7gCEVfjrzWzpARBuHcWxS4NS1Sg21zkC9KiIyRiXUFJ8fUnq9SacwJUJCIZhTriek8C4RTtjfAN7Fc2SvblLfW6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a6yjpPt5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e3EcPiaX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a6yjpPt5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e3EcPiaX" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65G64SkT2316349 for ; Tue, 16 Jun 2026 06:30:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ut2EE7DkqBeuZRCzWLedDy6SAnUsmxkY3D+ggtgilwo=; b=a6yjpPt53NxJBjEs ruOxtILPBDDXb5vZ0nvoH0Cim79CbVXAHDVuwWsXC5l6Pzthzrg/xMOaFEB4hUCB 3qRQgpmF7JRzJF9wuFvPPh2SEGmcagW7+mGFZe0OS8oVPOTtmZK47e64TGkZ2vDm rctL5a/k2wX7T3rN9KkK6UA2S3+//ERqQwCCvRIKiCEsCUMMh4ASFp5cniF74OwS ruZANZ2C9dF0o3ss9QVU0/6ozPF66P8c+wMoTv4gMUt+OAhb+QmYN7DR1gdXz5GP 9/Y/vsS3tVMgn/HbnY3eT9p1W1vdCPjENezooyVdMuGrCYmrubADyKbqQnRWbvtZ Gz7xew== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eteydd7fs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 06:30:41 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2c2a4babe45so24807565ad.2 for ; Mon, 15 Jun 2026 23:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781591441; x=1782196241; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ut2EE7DkqBeuZRCzWLedDy6SAnUsmxkY3D+ggtgilwo=; b=e3EcPiaXU8H6yewOphwz3JU5Lpf6VVP4wK5FgoT4ypbIP1/XQgcBJkTV90ixqqxe7I 7GHdoM4rI/8+Dg792iB9wmdo4w3DnFvvmyxghY+7IzJqzL2yukNEGKvBwt48q9pJzVWK 3p6bN9bW1YJFQIVc900+gfpUn9fjbYhzRFTcbSOiAfIkjdBbRix3cGuV9Mixp9cwqmy3 5c4O55frQRHMrrToKpqJ/OoOhhZQLwe6g88Jwln7RKLAIU0V1Bo1X4Ua3Mp6Yg/NHDaO do/4Q/sz4Za1vrIVJIBdftxDPiXVONCPypMZii17t6r9ChaPyA9SZltHdWM0z6b7VGCl jyMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781591441; x=1782196241; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ut2EE7DkqBeuZRCzWLedDy6SAnUsmxkY3D+ggtgilwo=; b=UdWKT9UyDe94WSArUuv34QecmavHTNaAClFbtCyj5Zs80SlT5DDCwWEsH2qVCkXiXb 11F5Ox3uIV++YPMK5KyS1QzvwsZKn/+iyAFqkWDOHbhlJ22s/9jlr7fuW592zj1SDw2+ gPcH1uAYtp5bBGkmAMWPZxBHBSL1bIS2YZXwE2d0Tf9stj6llnq81PoY4z8fd/bCIS9n Fon9Vs70lfiixrzJLVvXK7byQQj8DStAhF7Ex+acfKAJ94oqlIPrFQz3julFgdXN1Otz ENPqW+8oh1FjLqY2BNpzNoLRlLrxp7H2EZUsQwYQ6UAgPxMS1jhkXr5unwo/9zf5B9mL s7Vg== X-Forwarded-Encrypted: i=1; AFNElJ8pUAyrIFAsCtsWrwIH1DvFIesnv+KhHcY+7Q+8ERHTU7y3VeVdYg4YxsV0WD8NoEPHO1JlW/rS++meUPU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8GSauAC88Q5gAFq2KmSlMDdxWKkadPwnLGT2+xHGIGmQFFcxr JIjGJ2S0bV5w62ezyeQoVHmkoAHslwjLVX/ssPE+GpA4BqoLL4U3WfsaeA0ouTCbcw5T7JzwdxM mcBpQflyb0SCaobVlTqVNAbtG514ErGC/afi+QK6RqwI8X9ydrXaNCFCBNwB+dF1ne+A= X-Gm-Gg: Acq92OGH1XHNL7E2C/GmDrpsxdRnxp2bG4wzMUDxREkv/o6du3MnxziUUXIUwacNBBp kb1R015h+gnvZKUhxLrjD+ls4LVHlY9eT7iYjzpApeXC3jIR111L9zi2t6e71OrH88ae8z73RpG p/J6RJXRcWdteYQlA5v0NCh/fphgW8V7/LK+Sr0IfEDaCRany3pXAnaPlgn8M+eZ010h7xjcm6b y5TZHwqpc1YIxyCsYR80lHiyXJnjjJA81hNs3uxvOc/czOA1FK25y+/Vno9LI033JczwsUUKRnE nxlX77D0MPdPwgLm+C/LzYVCFIaAY5Li5zmzkmHUrQDopeFT7eIb0KnfjRUFHa8Eotp5ZXK+aps wiL478pIUNCsExmSxYrezazr7NiNlbBaPoaIpvNMtVWZSElqlFw== X-Received: by 2002:a17:902:ea06:b0:2c0:e5ee:f56c with SMTP id d9443c01a7336-2c664271b0amr151324905ad.20.1781591441092; Mon, 15 Jun 2026 23:30:41 -0700 (PDT) X-Received: by 2002:a17:902:ea06:b0:2c0:e5ee:f56c with SMTP id d9443c01a7336-2c664271b0amr151324535ad.20.1781591440688; Mon, 15 Jun 2026 23:30:40 -0700 (PDT) Received: from [10.217.216.182] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c4328a47f8sm113848585ad.47.2026.06.15.23.30.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 23:30:40 -0700 (PDT) Message-ID: <259de024-a1a8-4d0f-8290-fcf5c01919f1@oss.qualcomm.com> Date: Tue, 16 Jun 2026 12:00:33 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] clk: qcom: Add EVA clock controller driver for Glymur SoC To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260526-evacc_glymur-v1-0-b61c7755c403@oss.qualcomm.com> <20260526-evacc_glymur-v1-3-b61c7755c403@oss.qualcomm.com> <67d7280f-54e5-4e16-931c-92049bee3e00@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: <67d7280f-54e5-4e16-931c-92049bee3e00@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: EFm5l6Qg4zegYGWeJxyaO3LRqT4lPIju X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDA2MiBTYWx0ZWRfXyrIMftoM3fSn Nn57SWham7CFFIoLW21GN2PPfoSD9VORUee6+RAm0ZLOMTsPBEHAc/KpmOg/Aa6p7dv2f9OCPAv /q0YAbXxet8suQ19cWBpGo/DhvaEBh0= X-Authority-Analysis: v=2.4 cv=QrJuG1yd c=1 sm=1 tr=0 ts=6a30ed91 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=DWGL2ng0N4RBUu-NxngA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: EFm5l6Qg4zegYGWeJxyaO3LRqT4lPIju X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDA2MiBTYWx0ZWRfXxTnfxGojrxb0 M3xcTn39w1grPq+aO6chBemfqKzbdni7OqrHPtK0vl6dyRsYDrkxX7K0ylDFvnccS0xB2L+Mu82 GVuF1woLcbFYdN/sNNst9qzS6XLJ5kGpHT5q+rwXSCphYGUPSA4htZMeWR+wOanzTbKhctsT02M rjlwfXMBY+nTJRKYzlGnS2GpEs9Thkf8S3NY0d5dfC9hyuxd+WkJZy4//NkNGBC6k3DbPgwpZsC x0b42H+XtzPF5OP3C13WXZkYeAtm0JQ8ttT90aQHq8mGJmiriqFAdlNI1BE1xhsVaXuUZOprs7a uTncDz+RMMWVp+wUPHjqWTgXxBfW0AWANy9zF9rJN2cytXI9qpyT4y8M0XgaUwAJ4r6fjp23sxX SYWaDfDTVAGeb/uzQ9bDg6flD+FDwGeYCu8bU4vrRW9OsNX2xhLr5aGDl/fBGwBoj0Xf0zaQgxb xLjZplJwsLtLX523xeQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_02,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160062 On 6/11/2026 5:30 PM, Konrad Dybcio wrote: > On 5/26/26 7:29 AM, Taniya Das wrote: >> Add the Enhanced Video Analytics (EVA) clock controller driver for >> the Glymur SoC. The EVACC manages the PLL, RCGs, branch clocks, GDSCs >> and resets for the EVA subsystem which handles vision processing >> workloads. >> >> Signed-off-by: Taniya Das >> --- > > [...] > >> +enum { >> + DT_AHB_CLK, >> + DT_BI_TCXO, >> + DT_BI_TCXO_AO, > > DT_BI_TCXO_AO is unused, will it ever be? Not really, will drop in the next patch. > > [...] > >> +static void clk_glymur_regs_configure(struct device *dev, struct regmap *regmap) >> +{ >> + /* Update CTRL_IN register */ > > Is there any better comment we could share here? :) I will update this as well. > >> + regmap_update_bits(regmap, 0x9f24, BIT(0), BIT(0)); > > regmap_set_bits() Yes, will update this as well. > > otherwise lgtm > > Konrad -- Thanks, Taniya Das