From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B82CC2B9F4 for ; Mon, 14 Jun 2021 13:18:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D93C6134F for ; Mon, 14 Jun 2021 13:18:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233478AbhFNNUm (ORCPT ); Mon, 14 Jun 2021 09:20:42 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:40807 "EHLO mail-wr1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232825AbhFNNUc (ORCPT ); Mon, 14 Jun 2021 09:20:32 -0400 Received: by mail-wr1-f42.google.com with SMTP id y7so14516473wrh.7 for ; Mon, 14 Jun 2021 06:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XFmTmIPfKkU5RhaamFAr4BhwN+bI45kmR+Vj5S8aLqU=; b=MI23UFo2gw40h05XL7Pjtm04CvcZuvV3D76vFSblYhKAqMRSwGee6QT2SOz5MWEC5p wPEYoGXmtBbJp25N/LLJKUBrNpgzIc0BeeTZOAABDlQ7+Kg1DvWf+hXvrhCxYFDizznS VyWrPvoU1K+x+qtLSBXxlAILt8Gh5ueBIqmYycf+a5XsBThzzzh+7/w6T8yxakKT5hUv 4UfqScr2UVlMZ6xnhJmZ4gsN/GTjCTHk+V3Onk3Idn4h3ufVKvVR12QJclD+k8LHYlwb VeB6yNchqkFxqKmchayU8ty8HDq7xFYh4rpVSWJplvrZzJf7blR5ZAVZoJ7iLaHnpo2o EUSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=XFmTmIPfKkU5RhaamFAr4BhwN+bI45kmR+Vj5S8aLqU=; b=jBvWYYSoeUcQcpQjJbnB/0FS0NOpVweHrEL3aw1yodmzyv06GM+u5SLI+69usnVe0b RDLsz3Fv0pE7Ep6zW1Z7Had0mjYmXoWypDPo5WqJziBZGpJj8bTiKdcBJYHuXU+fLbQq GwpaD7S0B6Q2HvV/0yR/fT5QVaywR3E9m0Z6krhnNE67bzbCV9a+o4fRw3MfVN8dZ5Vv jl+L1EhbYGX8C83oVi8xKZL2yYLSP5TI5hIIDweoGzB598RrkcXpoIPcWZfiwWhDtmP9 MtGK9JMIx5Wuvd6RTLtrEH0kko0JA0USV3RXbRON/R3gXZkO2M4Cmu+CSa6ImNFQd0BX 0x6w== X-Gm-Message-State: AOAM533NCHeGa/vR7W3g14omp5qzrW2zXGecSm91TC14RCVGzdhUki6f Jm6Pr0uX0kinDUKtQ6zMq+dhvA3JqcHpkxqc X-Google-Smtp-Source: ABdhPJxjXjeRZW524D+N0JUBk4ULOtEQmBImEKhaFK8PHTuHPrQ61s0G80mnJlVwIQRwoR4b6kWf8g== X-Received: by 2002:a05:6000:18f:: with SMTP id p15mr18683034wrx.102.1623676649106; Mon, 14 Jun 2021 06:17:29 -0700 (PDT) Received: from ?IPv6:2a01:e0a:90c:e290:f0d4:3c02:f06a:77bb? ([2a01:e0a:90c:e290:f0d4:3c02:f06a:77bb]) by smtp.gmail.com with ESMTPSA id f13sm16372661wmg.7.2021.06.14.06.17.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jun 2021 06:17:28 -0700 (PDT) Subject: Re: [PATCH] arm64: dts: meson: vim3: reduce cpu thermal fan trigger temperature To: Daniel Lezcano , Nick Xie Cc: robh+dt@kernel.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Nick , artem@khadas.com References: <20210609012849.797576-1-xieqinick@gmail.com> <11da3ae4-91d4-1e51-c652-e4ad518f13bd@baylibre.com> <09c65310-9441-9b97-d9ae-4695f0dd16af@linaro.org> From: Neil Armstrong Organization: Baylibre Message-ID: <259e150c-f25a-86cf-1109-b7370b5d7c10@baylibre.com> Date: Mon, 14 Jun 2021 15:17:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <09c65310-9441-9b97-d9ae-4695f0dd16af@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/06/2021 09:45, Daniel Lezcano wrote: > On 11/06/2021 09:30, Nick Xie wrote: >> Hello Neil, >> >> >> Neil Armstrong 于2021年6月11日周五 下午3:15写道： >>> >>> Hi, >>> >>> On 11/06/2021 08:54, Nick Xie wrote: >>>> Hello Neil, >>>> >>>> The MCU FAN won't work until the temperature reach to 80 degree centigrade, >>>> Do you think the temperature is too high? >>> >>> I think 80 is tool high, but I fear 50 is way too low, but if you think 50 is OK after you ran some tests, just add it to the commit log and it's ok for me. >> >> I think it is OK, we use it for a long time. > > 50°C sounds like normal temperature with regular load. That means the > fan will be switched on most of the time when the board is used. > > And this change may be put in regard with the other trip points in the > common DT. For instance, enable the fan when reaching 80°C but set the > passive trip point to 75°C instead of 85°C. > > All that depends on the hardware characteristics and TDP which are in > the TRM normally. > I don't think such data exist in the datasheet or other public document, but the vendor source tree sets: - passive: 75°C - hot 85°C - critical 110°C we set upstream: - passive: 85°C - hot 95°C - critical 110°C so maybe we should lower the passive & hot trip points, then the FAN 80°C trip point would be ok now according to Daniel's explanation. Neil