From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946135AbcBRNNK (ORCPT ); Thu, 18 Feb 2016 08:13:10 -0500 Received: from mail5.windriver.com ([192.103.53.11]:36305 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1426012AbcBRNNF (ORCPT ); Thu, 18 Feb 2016 08:13:05 -0500 From: "Xue, Ying" To: Insu Yun , "jon.maloy@ericsson.com" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" CC: "taesoo@gatech.edu" , "yeongjin.jang@gatech.edu" , "insu@gatech.edu" , "changwoo@gatech.edu" Subject: RE: [PATCH] tipc: unlock in error path Thread-Topic: [PATCH] tipc: unlock in error path Thread-Index: AQHRaaLsTGA9PM+4Cka+gO50H9hbgZ8xxq9g Date: Thu, 18 Feb 2016 13:12:46 +0000 Message-ID: <25A14D9CFAB7B34FB9440F90AFD35233DD0AF10E@ALA-MBB.corp.ad.wrs.com> References: <1455727655-32106-1-git-send-email-wuninsu@gmail.com> In-Reply-To: <1455727655-32106-1-git-send-email-wuninsu@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [128.224.17.86] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u1IDDFcW013895 Acked-by: Ying Xue -----Original Message----- From: Insu Yun [mailto:wuninsu@gmail.com] Sent: 2016Äê2ÔÂ18ÈÕ 0:48 To: jon.maloy@ericsson.com; Xue, Ying; davem@davemloft.net; netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu; yeongjin.jang@gatech.edu; insu@gatech.edu; changwoo@gatech.edu; Insu Yun Subject: [PATCH] tipc: unlock in error path tipc_bcast_unlock need to be unlocked in error path. Signed-off-by: Insu Yun --- net/tipc/link.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/tipc/link.c b/net/tipc/link.c index 0c2944f..347cdc9 100644 --- a/net/tipc/link.c +++ b/net/tipc/link.c @@ -1973,8 +1973,10 @@ int tipc_nl_add_bc_link(struct net *net, struct tipc_nl_msg *msg) hdr = genlmsg_put(msg->skb, msg->portid, msg->seq, &tipc_genl_family, NLM_F_MULTI, TIPC_NL_LINK_GET); - if (!hdr) + if (!hdr) { + tipc_bcast_unlock(net); return -EMSGSIZE; + } attrs = nla_nest_start(msg->skb, TIPC_NLA_LINK); if (!attrs) -- 1.9.1