From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751260AbbIQLYU (ORCPT ); Thu, 17 Sep 2015 07:24:20 -0400 Received: from terminus.zytor.com ([198.137.202.10]:58846 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbbIQLYT (ORCPT ); Thu, 17 Sep 2015 07:24:19 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20150917093134.GC12316@nazgul.tnic> References: <20150917071920.GA14296@gmail.com> <20150917093134.GC12316@nazgul.tnic> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH 0/3] x86/paravirt: Fix baremetal paravirt MSR ops From: "H. Peter Anvin" Date: Thu, 17 Sep 2015 04:22:50 -0700 To: Borislav Petkov , Ingo Molnar CC: Andy Lutomirski , x86@kernel.org, Paolo Bonzini , Peter Zijlstra , KVM list , Arjan van de Ven , xen-devel , linux-kernel@vger.kernel.org, Linus Torvalds , Thomas Gleixner , Peter Zijlstra , Andrew Morton Message-ID: <25F7F434-556E-49E6-98F5-5879416CF87C@zytor.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org However, the difference between one CONFIG and another is quite frankly crazy. We should explicitly use the safe versions where this is appropriate, and then yes, we should do this. Yet another reason the paravirt code is batshit crazy. On September 17, 2015 2:31:34 AM PDT, Borislav Petkov wrote: >On Thu, Sep 17, 2015 at 09:19:20AM +0200, Ingo Molnar wrote: >> Most big distro kernels on bare metal have CONFIG_PARAVIRT=y (I >checked Ubuntu and >> Fedora), so we are potentially exposing a lot of users to problems. > >+ SUSE. > >> Crashing the bootup on an unknown MSR is bad. Many MSR reads and >writes are >> non-critical and returning the 'safe' result is much better than >crashing or >> hanging the bootup. > >... and prepending all MSR accesses with feature/CPUID checks is >probably almost >impossible. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.