mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: <broonie@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
	<alsa-devel@alsa-project.org>, <timur@tabi.org>,
	<Li.Xiubo@freescale.com>, <b02247@freescale.com>,
	<b42378@freescale.com>
Subject: [PATCH 2/2] ASoC: fsl_sai: Fix incorrect register writing in fsl_sai_isr()
Date: Thu, 17 Jul 2014 21:21:38 +0800	[thread overview]
Message-ID: <25a59f4a687232e0dd90376d640fbfd0eae65e2a.1405603108.git.nicoleotsuka@gmail.com> (raw)
In-Reply-To: <cover.1405603108.git.nicoleotsuka@gmail.com>

In the rx irq handling part, we should clear the flags in RCSR not TCSR.

Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
---
 sound/soc/fsl/fsl_sai.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index b10dbd8..1b6ee2c 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -106,7 +106,7 @@ irq_rx:
 	xcsr &= ~FSL_SAI_CSR_xF_MASK;
 
 	if (flags)
-		regmap_write(sai->regmap, FSL_SAI_TCSR, flags | xcsr);
+		regmap_write(sai->regmap, FSL_SAI_RCSR, flags | xcsr);
 
 out:
 	if (irq_none)
-- 
1.8.4


  parent reply	other threads:[~2014-07-17 13:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17 13:21 [PATCH 0/2] ASoC: fsl_sai: Two bug fixes for fsl_sai driver Nicolin Chen
2014-07-17 13:21 ` [PATCH 1/2] ASoC: fsl_sai: Reset FIFOs after disabling TE/RE Nicolin Chen
2014-07-18 10:18   ` Nicolin Chen
2014-07-23  9:52     ` Nicolin Chen
2014-07-23 10:07       ` Mark Brown
2014-07-23  9:59         ` Nicolin Chen
2014-07-17 13:21 ` Nicolin Chen [this message]
2014-07-18  2:38 ` [PATCH 0/2] ASoC: fsl_sai: Two bug fixes for fsl_sai driver Li.Xiubo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25a59f4a687232e0dd90376d640fbfd0eae65e2a.1405603108.git.nicoleotsuka@gmail.com \
    --to=nicoleotsuka@gmail.com \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=b02247@freescale.com \
    --cc=b42378@freescale.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®