From: Thorsten Leemhuis <linux@leemhuis.info>
To: Jeffery Miller <jefferymiller@google.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: regressions@lists.linux.dev, benjamin.tissoires@redhat.com,
Andrew Duggan <aduggan@synaptics.com>,
Andrew Duggan <andrew@duggan.us>,
loic.poulain@linaro.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: [PATCH] Input: elantech - fix fast_reconnect callback in ps2 mode
Date: Tue, 10 Oct 2023 09:08:23 +0200 [thread overview]
Message-ID: <25ac6b17-e3fa-4e98-95a6-eac12bdbcdd2@leemhuis.info> (raw)
In-Reply-To: <CAAzPG9Pp6mHfEziJiUuhDRmkKMfiiPD6axtfAMaCJcEAcuQPiA@mail.gmail.com>
On 05.10.23 02:13, Jeffery Miller wrote:
>
> On Wed, Oct 4, 2023 at 9:11 AM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>>
>> In fact, now that I think about it more, we should rework the original
>> patch that added the delay, so that we do not wait these 30 msec in the
>> "fast" reconnect handler. It turns out your original approach was
>> better, but we should not be using retries, but rather the existing
>> reset_delay_ms already defined in rmi platform data. I would appreciate
>> if you try the draft patch at the end of this email (to be applied after
>> reverting your original one adding the delay in psmouse-smbus.c).
> I tested the draft patch and it works. I did revert the previous delay
> patch while testing it.
>
>> I think we need a similar change in synaptics.c as that one also can
>> fall back to PS/2 mode.
>>
> Ah, good point, yes it does appear this needs to be done as well.
> I have tested and will post an new version of the patch to include
> the fix in synaptics.c as well.
As I'm affected by this problem (and somebody else reported to me in
private to be affected as well) and nothing afaics happened in the past
few days a quick question:
What's the way forward here now that -rc6 slowly comes into sight? Apply
Jeff's patch to fix my problem? Revert the culprit and fix this properly
up with Dmitry's and Jeff's patches in the next cycle? Something else?
Ciao, Thorsten
next prev parent reply other threads:[~2023-10-10 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 0:57 Jeffery Miller
2023-10-04 5:07 ` Thorsten Leemhuis
2023-10-04 6:19 ` Greg Kroah-Hartman
2023-10-04 6:34 ` Thorsten Leemhuis
2023-10-05 0:35 ` Jeffery Miller
2023-10-04 14:10 ` Dmitry Torokhov
2023-10-05 0:13 ` Jeffery Miller
2023-10-10 7:08 ` Thorsten Leemhuis [this message]
2023-10-12 22:53 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ac6b17-e3fa-4e98-95a6-eac12bdbcdd2@leemhuis.info \
--to=linux@leemhuis.info \
--cc=aduggan@synaptics.com \
--cc=andrew@duggan.us \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jefferymiller@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®