Re: PROBLEM: Oops in Kernel 2.6.15 usbhid

[Patrick Read <pread99999@gmail.com>]

On 1/9/06, Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> On Friday 06 January 2006 01:25, Patrick Read wrote:
> > [1.] Oops in Kernel 2.6.15 usbhid
> >
> > [2.] Compiled 2.6.15 downloaded from kernel.org.  Configured, made,
> > and installed.  During reboot, I get an Oops in the USB HID module.
> > This does not occur with a nearly-identical config on the same
> > computer with kernel 2.6.14.5.
> >
> > [3.] USB, HID, kernel, 2.6.15, module
> >
>
> Could you please try the patch below? Thanks!
>
> --
> Dmitry
>
> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> ---
>
>  drivers/usb/input/pid.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: work/drivers/usb/input/pid.c
> ===================================================================
> --- work.orig/drivers/usb/input/pid.c
> +++ work/drivers/usb/input/pid.c
> @@ -259,7 +259,7 @@ static int hid_pid_upload_effect(struct
>  int hid_pid_init(struct hid_device *hid)
>  {
>         struct hid_ff_pid *private;
> -       struct hid_input *hidinput = list_entry(&hid->inputs, struct hid_input, list);
> +       struct hid_input *hidinput = list_entry(hid->inputs.next, struct hid_input, list);
>         struct input_dev *input_dev = hidinput->input;
>
>         private = hid->ff_private = kzalloc(sizeof(struct hid_ff_pid), GFP_KERNEL);
>

The above fix works like a charm.  2.6.15 is running on this very
computer that I'm typing on.

Thank you for your good work.  Please ensure that this fix gets
incorporated in the mainline kernel.

Patrick