From: Jaehoon Chung <jh80.chung@samsung.com>
To: Alexander Kochetkov <al.kochet@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming
Date: Thu, 20 Apr 2017 19:06:12 +0900 [thread overview]
Message-ID: <25b5c103-ed7c-d03f-d285-bde651691ba1@samsung.com> (raw)
In-Reply-To: <1492613756-16740-1-git-send-email-al.kochet@gmail.com>
Hi Alexander,
On 04/19/2017 11:55 PM, Alexander Kochetkov wrote:
> Commit e9748e0364fe ("mmc: dw_mmc: force setup bus if active slots exist")
> made a change resulted in clock message appears every time the card is
> resuming (every 5 second in average). Add condition that previously used to
> print the message.
I think you are not using the latest kernel. which version do you use?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce69e2fea093b7fa3991c87849c4955cd47796c9
Could you check this?
Best Regards,
Jaehoon Chung
>
> Fixes: e9748e0364fe ("mmc: dw_mmc: force setup bus if active slots exist")
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> ---
> drivers/mmc/host/dw_mmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 73db085..faaf2c1 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1178,7 +1178,8 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot, bool force_clkinit)
>
> if ((clock != slot->__clk_old &&
> !test_bit(DW_MMC_CARD_NEEDS_POLL, &slot->flags)) ||
> - force_clkinit) {
> + (force_clkinit &&
> + (slot->mmc->pm_flags & MMC_PM_KEEP_POWER))) {
> dev_info(&slot->mmc->class_dev,
> "Bus speed (slot %d) = %dHz (slot req %dHz, actual %dHZ div = %d)\n",
> slot->id, host->bus_hz, clock,
>
next prev parent reply other threads:[~2017-04-20 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170419145649epcas2p428230d6fa04b2b6905e500f7b0a33297@epcas2p4.samsung.com>
2017-04-19 14:55 ` Alexander Kochetkov
2017-04-20 10:06 ` Jaehoon Chung [this message]
2017-04-20 13:50 ` Alexander Kochetkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25b5c103-ed7c-d03f-d285-bde651691ba1@samsung.com \
--to=jh80.chung@samsung.com \
--cc=al.kochet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®