From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757892AbdEVJOe (ORCPT ); Mon, 22 May 2017 05:14:34 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:32828 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757552AbdEVJOc (ORCPT ); Mon, 22 May 2017 05:14:32 -0400 Subject: Re: [Ocfs2-devel] [PATCH] ocfs2: fix a static checker warning To: Gang He , mfasheh@versity.com, jlbec@evilplan.org References: <1495428877-7440-1-git-send-email-ghe@suse.com> Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com From: Joseph Qi Message-ID: <25bc4d76-b5d2-4ae7-7a1d-78e395b9778d@gmail.com> Date: Mon, 22 May 2017 17:14:13 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1495428877-7440-1-git-send-email-ghe@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/5/22 12:54, Gang He wrote: > This patch will fix a static checker warning, this warning was > caused by commit d56a8f32e4c662509ce50a37e78fa66c777977d3. after > apply this patch, the error return value will not be NULL(zero). > > Signed-off-by: Gang He Reviewed-by: Joseph Qi Thanks, Joseph > --- > fs/ocfs2/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c > index 382401d..1a1e007 100644 > --- a/fs/ocfs2/inode.c > +++ b/fs/ocfs2/inode.c > @@ -136,7 +136,7 @@ struct inode *ocfs2_ilookup(struct super_block *sb, u64 blkno) > struct inode *ocfs2_iget(struct ocfs2_super *osb, u64 blkno, unsigned flags, > int sysfile_type) > { > - int rc = 0; > + int rc = -ESTALE; > struct inode *inode = NULL; > struct super_block *sb = osb->sb; > struct ocfs2_find_inode_args args; >