From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A806274B40 for ; Mon, 2 Feb 2026 17:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770052836; cv=none; b=XECE6Eaq9Ix9aLnkQXc9GK57/bXO2ZwlfRm5n/2oBgwEYyn7nP6LczL+pTcIxe8gaVGUj7OQgb284YMVQRdPIgJPh1O13Xu6PrrLzK6vcIhJChRLiqGP6kZ92TWQGGoeHVZ8bfLzXhDVG38V/EfQaOKCTZMdVFIiw1SU/uZiX48= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770052836; c=relaxed/simple; bh=a3QekfMeF0DCtIw1H9A5ab6FXw824gdVFqGbb32mEeQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NVmXG4iEdyZCDaEvm9+4Agp4nK8nAJ2KxVtdOsJOBWqPRuLQf/Luq5TKHYufXYPfL3GDxws7Xn9IW0I0iWlU5+LLylyiznDFcYmt00lzhb6IbZB1tErm0R+d6gCluR2TEwQ0kAolJM0tjOHAIwyLnpH/wyVvEyq3sHkrlnRx7Sg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=uI/HwipC; arc=none smtp.client-ip=209.85.210.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="uI/HwipC" Received: by mail-ot1-f66.google.com with SMTP id 46e09a7af769-7d193b01c10so1893940a34.3 for ; Mon, 02 Feb 2026 09:20:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1770052832; x=1770657632; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=idcn5ztOB8vCVixROzXdUZZgLSFHdenUmBztFP1iIws=; b=uI/HwipC6z5w1+7FQg5j07vhUoTiqHQijl0StO5mBL1xh3wv6pLbvpKRNYB82s3KvW xPp0j2lUQpbizgsieQcR7uXy8ggtyQvkvMtYboO/qYEwofLT41tsM93SjsTWdlDX80UV o+aIHTZQtHaMN0IUOWVNkOrXLMqGZ+vCv4WyoC5BRsH8O8zavcDP7xLFSc7Ya9PywPip yufjiVhBJcNbZVNW3y/0x215+cOBikrT49WkuFmsuKmn4YSI6cyfzNhfDkVjlkeJW8Cu bWY2PGCdDMzk2LNn8qq0Ti+nTkIEbQxW28goi46RTc3+7ry8DlITe1eO7iE/CcQDIiYQ 282Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770052832; x=1770657632; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=idcn5ztOB8vCVixROzXdUZZgLSFHdenUmBztFP1iIws=; b=NE8/Aic6aN3zsIdlmRYPjbkC2OJnqIcZdh97Pm0aGjZvC6BhVM+msL6sV7a1tsKsDG FJmhxIAZ3cwte8z+hzTTyMv66weIZ/xgMPsrvRDsP1ERUrVKYoK7nSGchULxVuvISmcl XL55Ih7yHkDLNBuMDdxo3mneHl4C0Im3ZimuYJ1qxQJxzq94lUibGTj8hG3/riayfYqg FyNCnwIF2L4OANitd7/DE/5jfFoMV8eFNuo9LkT623UuMjOLorW+U0IqgDTZDVGKBq2y Hxqb1FbL/eJn/evNx5I0vpMdOOqm/aErpoz734lugNAccskTIak1WaoPGSALHQAv+6aL lSsg== X-Forwarded-Encrypted: i=1; AJvYcCWU2aGYIqcenpxpydsJq6zThj3+Vg5/t+icJc7c8KYJDr/aUq3zIhm45DFdYBsjIZeOEnOphEaWMV/9wzQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp0+3lp33bwDvXGZxw8/I4OiMNRmNA4nWXHhYYbwO7ponP+F7l dZH8SGe/VjS4FjVrwZD7PzgYO9Kck7OwG6tbxI/VNN7GTCyyHmf5OTS/IsTpH/+uzrQ= X-Gm-Gg: AZuq6aLSV7E0wnyLVZPJr8JbDaYXSMSUIq4GQSHyl7EMfqMDZE+xcGSu76Y/VTYFL+1 uiYxig7QGCFeUSwXabpeKwpIvB3md58tI7ropVj3aOMRL4URpQop3mjPYzcQQHPIsM6lswHu6RL koYm4Y/JlPPRgmLa2J8AQF7MMdiwBXmkEMjEj6tDxIfeSIGa4T2w2AfSnDEIZL1bcykab3BP7XH w7NakxW9rmqaDqs5+rg8nBBmc7ZQAMvOWhbGfw/KB+dX1ThbUWqWAqFNehEKRmKMbycNTYH3+hh CQsYQu2fiGit5gshLNb/sSoDSCU8Ah+ymYkkV2RmZuRkNsTAMOypXuBrXxFW4WycJOwpAfx5LJM XwSEZTPrjIsAPVGo/aXx7shuEC+cHg0ayUOk+Ka9H0I3YcA7NK/Phun094QLK/qr8wFXc2Bs5vX K9Yr28RcAibLvL4pjrpZoeQrYG1gnwXVTlEYBXodRAcp0zchu8YDjzvTxg/OIJ X-Received: by 2002:a05:6830:6584:b0:7cf:e41d:f0b0 with SMTP id 46e09a7af769-7d1a5341a34mr6832027a34.18.1770052832041; Mon, 02 Feb 2026 09:20:32 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:3695:6954:27c2:42ef? ([2600:8803:e7e4:500:3695:6954:27c2:42ef]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d18c7ffcc7sm10907066a34.23.2026.02.02.09.20.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 09:20:31 -0800 (PST) Message-ID: <25bc9ae2-5c27-407a-aae4-6c619367664a@baylibre.com> Date: Mon, 2 Feb 2026 11:20:30 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: mediatek: mt8365: Describe infracfg-nao as a pure syscon To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Alexandre Mergnat , Amjad Ouled-Ameur , =?UTF-8?Q?Bernhard_Rosenkr=C3=A4nzer?= , Fabien Parent Cc: kernel@collabora.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20250502-mt8365-infracfg-nao-compatible-v1-0-e40394573f98@collabora.com> <20250502-mt8365-infracfg-nao-compatible-v1-2-e40394573f98@collabora.com> Content-Language: en-US From: David Lechner In-Reply-To: <20250502-mt8365-infracfg-nao-compatible-v1-2-e40394573f98@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/2/25 11:43 AM, Nícolas F. R. A. Prado wrote: > The infracfg-nao register space at 0x1020e000 has different registers > than the infracfg space at 0x10001000, and most importantly, doesn't > contain any clock controls. Therefore it shouldn't use the same > compatible used for the mt8365 infracfg clocks driver: > mediatek,mt8365-infracfg. Since it currently does, probe errors are > reported in the kernel logs: > > [ 0.245959] Failed to register clk ifr_pmic_tmr: -EEXIST > [ 0.245998] clk-mt8365 1020e000.infracfg: probe with driver clk-mt8365 failed with error -17 > > This register space is used only as a syscon for bus control by the > power domain controller, so in order to properly describe it and fix the > errors, set its compatible to a distinct compatible used exclusively as > a syscon, drop the clock-cells, and while at it rename the node to > 'syscon' following the naming convention. > > Fixes: 6ff945376556 ("arm64: dts: mediatek: Initial mt8365-evk support") > Signed-off-by: Nícolas F. R. A. Prado > --- > arch/arm64/boot/dts/mediatek/mt8365.dtsi | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > index e6d2b3221a3b7a855129258b379ae4bc2fd05449..49ad4dee9c4cf563743dc55d5e0b055cfb69986a 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi > @@ -495,10 +495,9 @@ iommu: iommu@10205000 { > #iommu-cells = <1>; > }; > > - infracfg_nao: infracfg@1020e000 { > - compatible = "mediatek,mt8365-infracfg", "syscon"; > + infracfg_nao: syscon@1020e000 { > + compatible = "mediatek,mt8365-infracfg-nao", "syscon"; > reg = <0 0x1020e000 0 0x1000>; > - #clock-cells = <1>; > }; > > rng: rng@1020f000 { > Reviewed-by: David Lechner It looks like this never got picked up. I noticed this was a problem in U-Boot because it was registering this as a clock provider. And I sent a similar patch [1] recently that has also not been acted on yet. I prefer this patch since it also fixes the node name to use a standard name. Who should be responsible for actually picking up the patch? [1]: https://lore.kernel.org/linux-mediatek/20251216-mtk-fix-infracfg_nao-compatibile-v1-1-d339b151ac81@baylibre.com/