From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E7EC83D2FFC for ; Thu, 16 Jul 2026 10:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784196387; cv=none; b=r0VbBAgPB5jKcKx3CLlo2t22wgZgtyS8DBShogWg5aDFEVMCCbGFxGT2ntw+H7BAOvh7OAKbFyTGPwei/EWIUsypCYr/b4n46nqhhGpP69DtPrJm0astf9uIcsCHggs/yNdkC5sip3VT+Ssl7B989y4u198Koil9ULfuWiiYt20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784196387; c=relaxed/simple; bh=8rNQfiQ8v/L+ZzRfXT15f1M/HWmP0kVb0q/6/VtZWvk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WytV+/E3Eh9iGCO5cRnQalinTsatZag8iqqVJWkBznbayUXttJDr+Qte2lOXx1xKMqNu8R7rfoMCMDpMO+fqDsYI5BHePL/bO8Jm0qOfuO8iMk7XKQho+iUyqv3JwL9H4x01TFHEQ5C7CeJKr1y4fU8CXtxR6pGNr22D9IfZdOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=E7F4mNvt; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="E7F4mNvt" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 018B02F; Thu, 16 Jul 2026 03:06:20 -0700 (PDT) Received: from [10.164.19.52] (unknown [10.164.19.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5F8003F7B4; Thu, 16 Jul 2026 03:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784196384; bh=8rNQfiQ8v/L+ZzRfXT15f1M/HWmP0kVb0q/6/VtZWvk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=E7F4mNvtVoNEg++pnYbRIjSDaJt8m/GZWkvWGMnobGbJjC9QU9j2sJRANV0GToaCm SxaEMfmyIMqJAxyYROsfrT+lXRl2df9p+7+s78UOuwQ+2KpIhbUgxtpd1vjrAuXQ9W mDEF2KdsYQfyInP6X64Uat/uSZ498Bj+Mmn0gbrE= Message-ID: <25bf1106-5739-4d54-8dac-7a5851d45b3d@arm.com> Date: Thu, 16 Jul 2026 15:36:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm/memory: move pte_install_uffd_wp_if_needed() into memory.c To: "David Hildenbrand (Arm)" , akpm@linux-foundation.org, ljs@kernel.org Cc: liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, kasong@tencent.com, qi.zheng@linux.dev, shakeel.butt@linux.dev, baohua@kernel.org, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, riel@surriel.com, harry@kernel.org, jannh@google.com, lance.yang@linux.dev, ryan.roberts@arm.com, anshuman.khandual@arm.com References: <20260715111839.1667914-1-dev.jain@arm.com> <20260715111839.1667914-2-dev.jain@arm.com> <91231124-acd6-4b50-8d61-fa4e2e076649@kernel.org> Content-Language: en-US From: Dev Jain In-Reply-To: <91231124-acd6-4b50-8d61-fa4e2e076649@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/07/26 3:05 pm, David Hildenbrand (Arm) wrote: > On 7/15/26 13:18, Dev Jain wrote: >> pte_install_uffd_wp_if_needed() has grown too large for mm_inline.h. >> Move it to memory.c. >> >> While at it, convert the comment to kerneldoc and rename the local >> arguments from pte/pteval to ptep/pte so the pointer and pte value >> are easier to distinguish. >> >> Signed-off-by: Dev Jain >> --- >> include/linux/mm.h | 2 ++ >> include/linux/mm_inline.h | 53 ---------------------------------- >> mm/memory.c | 60 +++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 62 insertions(+), 53 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 550fb92957d18..a71341c44655e 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -5406,4 +5406,6 @@ void map_anon_folio_pte_nopf(struct folio *folio, pte_t *pte, >> struct vm_area_struct *vma, unsigned long addr, >> bool uffd_wp); >> >> +bool pte_install_uffd_wp_if_needed(struct vm_area_struct *vma, >> + unsigned long addr, pte_t *ptep, pte_t pte); > > This could probably go to mm/internal.h instead? > > Apart from that LGTM. Correct, I'll do that. >