From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbdFTKwD (ORCPT ); Tue, 20 Jun 2017 06:52:03 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:33483 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102AbdFTKwB (ORCPT ); Tue, 20 Jun 2017 06:52:01 -0400 X-AuditID: cbfec7f2-f797e6d000004438-ee-5948fe4dca83 Subject: Re: [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event To: Thierry Escande Cc: Jacek Anaszewski , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org From: Andrzej Pietrasiewicz Message-id: <25bfed86-d208-4f70-5b55-d3eb56ba9ed5@samsung.com> Date: Tue, 20 Jun 2017 12:51:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8; format=flowed Content-language: en-US Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsWy7djP87q+/zwiDQ7OsrS4vXUDi8XlXXPY LHo2bGW1WLbpD5NF/9VLbA6sHjvuLmH02DnrLrvHplWdbB6fN8kFsERx2aSk5mSWpRbp2yVw ZdzcU1wwmb+ifeIE5gbGxdxdjJwcEgImEh+efmOGsMUkLtxbz9bFyMUhJLCUUWL2s/0sEM5n RonGwy+YYDq6Lx5hgkgsY5TYsv8tlPOCUeLp4++sIFXCAuESS5u2gc0VETCWWHtsN1gRs8Ac RonuWX/AitiAEnsPdjCC2LwCdhIT1lxhA7FZBFQlWl4+ZQexRQUiJBZNmsgOUSMo8WPyPaCb ODg4BRwltt9wBQkzC1hJPPvXygphi0s0t95kgbDlJTavecsMsldCYBm7xMItL5lBeiUEZCU2 HYD62UXi6LwvUJ8JS7w6voUdwpaRuDy5mwWidzKjxIabH6Cc7YxA35xghaiyljh8/CLUZj6J SdumQy3glehoE4Io8ZD4euEZI4TtKHGteyM0gC8ySfz63cU6gVFhFpLfZiF5aBaSh2YheWgB I8sqRpHU0uLc9NRiY73ixNzi0rx0veT83E2MwCRz+t/xTzsYv56wOsQowMGoxMO74LV7pBBr YllxZe4hRgkOZiURXp6THpFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeblOXYsQEkhPLEnNTk0t SC2CyTJxcEo1MAbUrc1YmP/llj/ngd+zg2dHvWW/Z769azNbeE2IlX3ZvVv9rPLFdz7zf/mk 0F1bsqb/rkHFYt6z2ZMvf858pPNV2c8ydKL4G+nGQpsTex7kz1hev+d4yw0eQYl/+eKbF+24 YHLcJq3LTO/kR63ZP1o3Xc/527vJrVXgqNL8/a2iXc8OVYQ+fK7EUpyRaKjFXFScCAAtNuL3 LgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsVy+t/xK7q+/zwiDdat5ba4vXUDi8XlXXPY LHo2bGW1WLbpD5NF/9VLbA6sHjvuLmH02DnrLrvHplWdbB6fN8kFsES52WSkJqakFimk5iXn p2TmpdsqhYa46VooKeQl5qbaKkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLePmnuKCyfwV 7RMnMDcwLubuYuTkkBAwkei+eIQJwhaTuHBvPVsXIxeHkMASRol7BxazQzgvGCX2rrvKAlIl LBAucf1lJ1iHiICxxNpju5lAipgF5jBKbN5wiRkkISRwkUli0tskEJsNqGjvwQ5GEJtXwE5i wporbCA2i4CqRMvLp+wgtqhAhMSu6wdYIWoEJX5Mvge0jIODU8BRYvsNV5Aws4CZxJeXh1kh bHGJ5tabLBC2vMTmNW+ZJzAKzkLSPQtJyywkLbOQtCxgZFnFKJJaWpybnltspFecmFtcmpeu l5yfu4kRGG3bjv3csoOx613wIUYBDkYlHt4Fr90jhVgTy4orcw8xSnAwK4nw8pz0iBTiTUms rEotyo8vKs1JLT7EaAr020RmKdHkfGAiyCuJNzQxNLc0NDK2sDA3MlIS55364Uq4kEB6Yklq dmpqQWoRTB8TB6dUA+OuUxPeLE+bln1T8IwKl+Ynu+UVE0M2nvORaa2L4lyvuJe/ZoXSX6se g9MaB/56/zXff2x1qwPXzW3XikPuvn58+URxg2Ty559HCl8EcVsd337p6cvUD19ao5axxN/X Z3uyV/XJ+1S3n9uzWUSV9b0DtE8GzW8wMbnhGlvws2PO785n760v7NNUYinOSDTUYi4qTgQA YVJefswCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170620105157eucas1p1585e7357553a81899dcd87819c71b815 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBQaWV0cmFzaWV3aWN6G1NSUE9MLUtlcm5lbCAo?= =?UTF-8?B?VFApG+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBUb21hc3ogUGlldHJhc2lld2ljehtTUlBPTC1L?= =?UTF-8?B?ZXJuZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2Fy?= =?UTF-8?B?ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170612171431epcas5p19a448035865da056440a819f17875601 X-RootMTR: 20170612171431epcas5p19a448035865da056440a819f17875601 References: <1497287605-20074-1-git-send-email-thierry.escande@collabora.com> <1497287605-20074-6-git-send-email-thierry.escande@collabora.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thierry, W dniu 19.06.2017 o 15:50, Thierry Escande pisze: > Hi Andrzej, > > On 16/06/2017 17:38, Andrzej Pietrasiewicz wrote: >> Hi Thierry, >> >> Thank you for the patch. >> >> Can you give a use case for resolution change event? > Unfortunately, the original commit does not mention any clear use case. > I've asked to the patch author for more information. Can you please share what you learn about it if the author gets back to you? Now that we don't know why to apply a patch I guess we should not do it. > >>> @@ -2510,43 +2567,18 @@ static void s5p_jpeg_buf_queue(struct >>> vb2_buffer *vb) >>> return; >>> } >>> - q_data = &ctx->out_q; >>> - q_data->w = tmp.w; >>> - q_data->h = tmp.h; >>> - q_data->sos = tmp.sos; >>> - memcpy(q_data->dht.marker, tmp.dht.marker, >>> - sizeof(tmp.dht.marker)); >>> - memcpy(q_data->dht.len, tmp.dht.len, sizeof(tmp.dht.len)); >>> - q_data->dht.n = tmp.dht.n; >>> - memcpy(q_data->dqt.marker, tmp.dqt.marker, >>> - sizeof(tmp.dqt.marker)); >>> - memcpy(q_data->dqt.len, tmp.dqt.len, sizeof(tmp.dqt.len)); >>> - q_data->dqt.n = tmp.dqt.n; >>> - q_data->sof = tmp.sof; >>> - q_data->sof_len = tmp.sof_len; >>> - >>> - q_data = &ctx->cap_q; >>> - q_data->w = tmp.w; >>> - q_data->h = tmp.h; >> >> >> Why is this part removed? > This has not been removed. > The &tmp s5p_jpeg_q_data struct was passed to s5p_jpeg_parse_hdr() and > then copied field-by-field into ctx->out_q (through q_data pointer). > With this change ctx->out_q is passed to s5p_jpeg_parse_hdr() and this > avoids the copy. It seems that changing field-by-field copying to passing a pointer directly to s5p_jpeg_parse_hdr() is an unrelated change and as such should be in a separate patch. Andrzej