mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf script: Simplify auxiliary event printing functions
Date: Fri, 3 Apr 2020 13:31:07 +0300	[thread overview]
Message-ID: <25c0b5e1-5888-5086-0921-8b0400e62863@intel.com> (raw)
In-Reply-To: <20200403100111.GI2784502@krava>

On 3/04/20 1:01 pm, Jiri Olsa wrote:
> On Thu, Apr 02, 2020 at 05:15:48PM +0300, Adrian Hunter wrote:
>> This simplifies the print functions for the following perf script
>> options:
>>
>> 	--show-task-events
>> 	--show-namespace-events
>> 	--show-cgroup-events
>> 	--show-mmap-events
>> 	--show-switch-events
>> 	--show-lost-events
>> 	--show-bpf-events
>>
>> Example:
>> 	# perf record --switch-events -a -e cycles -c 10000 sleep 1
>>  Before:
>> 	# perf script --show-task-events --show-namespace-events --show-cgroup-events --show-mmap-events --show-switch-events --show-lost-events --show-bpf-events >out-before.txt
>>  After:
>> 	# perf script --show-task-events --show-namespace-events --show-cgroup-events --show-mmap-events --show-switch-events --show-lost-events --show-bpf-events >out-after.txt
>> 	# diff -s out-before.txt out-after.txt
>> 	Files out-before.txt and out-after.tx are identical
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>> ---
>>  tools/perf/builtin-script.c | 304 ++++++++----------------------------
>>  1 file changed, 66 insertions(+), 238 deletions(-)
> 
> awesome ;-)
> 
>>
>> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
>> index 186ebf827fa1..348fec9743a4 100644
>> --- a/tools/perf/builtin-script.c
>> +++ b/tools/perf/builtin-script.c
>> @@ -2040,7 +2040,7 @@ static int cleanup_scripting(void)
>>  
>>  static bool filter_cpu(struct perf_sample *sample)
>>  {
>> -	if (cpu_list)
>> +	if (cpu_list && sample->cpu != (u32)-1)
>>  		return !test_bit(sample->cpu, cpu_bitmap);
> 
> why is this needed? filter_cpu seems to be already called
> from all the changed functions..

Yes, just paranoia


  reply	other threads:[~2020-04-03 10:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 14:15 Adrian Hunter
2020-04-03 10:01 ` Jiri Olsa
2020-04-03 10:31   ` Adrian Hunter [this message]
2020-04-03 10:48 ` Jiri Olsa
2020-04-06 13:39   ` Arnaldo Carvalho de Melo
2020-04-22 12:17 ` [tip: perf/core] " tip-bot2 for Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25c0b5e1-5888-5086-0921-8b0400e62863@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®