mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Tom Rini <trini@konsulko.com>, Francesco Dolcini <francesco@dolcini.it>
Cc: <u-boot@lists.denx.de>, <nm@ti.com>, <vigneshr@ti.com>,
	<kristo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>,
	<s-vadapalli@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-*: Replace rgmii-rxid with rgmii-id for CPSW ports
Date: Tue, 13 Jan 2026 16:10:27 +0530	[thread overview]
Message-ID: <25c59291bdf9dbdf01d5225e20062b19f4852b28.camel@ti.com> (raw)
In-Reply-To: <20260112180637.GR3416603@bill-the-cat>

On Mon, 2026-01-12 at 12:06 -0600, Tom Rini wrote:
> On Mon, Jan 12, 2026 at 08:56:36AM +0100, Francesco Dolcini wrote:
> > On Mon, Jan 12, 2026 at 08:49:56AM +0100, Francesco Dolcini wrote:
> > > +Tom +U-Boot ML
> > > 
> > > Hello Siddharth,
> > > 
> > > On Sat, Oct 25, 2025 at 01:07:59PM +0530, Siddharth Vadapalli wrote:
> > > > The MAC Ports across all of the CPSW instances (CPSW2G, CPSW3G, CPSW5G and
> > > > CPSW9G) present in various K3 SoCs only support the 'RGMII-ID' mode. This
> > > > correction has been implemented/enforced by the updates to:
> > > > a) Device-Tree binding for CPSW [0]
> > > > b) Driver for CPSW [1]
> > > > c) Driver for CPSW MAC Port's GMII [2]
> > > > 
> > > > To complete the transition from 'RGMII-RXID' to 'RGMII-ID', update the
> > > > 'phy-mode' property for all CPSW ports by replacing 'rgmii-rxid' with
> > > > 'rgmii-id'.
> > > > 
> > > > [0]: commit 9b357ea52523 ("dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example")
> > > > [1]: commit ca13b249f291 ("net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay")
> > > > [2]: commit a22d3b0d49d4 ("phy: ti: gmii-sel: Always write the RGMII ID setting")
> > > 
> > > What about U-Boot?
> > > I just noticed this in today U-Boot master:
> > > 
> > >   RGMII mode without internal TX delay unsupported; please fix your Device Tree
> > > 
> > > and I think this is coming from the DTS update from Linux to U-Boot.
> > > 
> > > Can you look into that?
> > 
> > Ok, I think that the issue is that the U-Boot code was updated
> > correctly, but now we need the v6.19 DT in U-Boot, and as of now we have
> > 6.18 DT.
> > 
> > Tom: are you planning to sync the U-Boot DT to Linux v6.19 before the next
> > U-Boot release?
> 
> Once it's out, yes. But, uh, this tells me some TI folks forgot to
> backport all of the dts changes too then as we shouldn't have broken
> platforms in-tree like this.

In both Linux and U-Boot, the error (warning) message:
    RGMII mode without internal TX delay unsupported; please fix your
Device Tree
only indicates that the device-tree should be updated to use 'rgmii-id'
instead of 'rgmii-rxid'. The functionality however remains unaffected. The
current Linux device-tree patch is not really fixing an issue from a
functionality perspective, and the same holds true for U-Boot.

I realize however that a DT sync patch could (should) have been posted by
me to the U-Boot mailing list after this patch had been merged to Linux
instead of waiting for the periodic DT sync.

Regards,
Siddharth.

      reply	other threads:[~2026-01-13 10:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-25  7:37 Siddharth Vadapalli
2025-11-03  4:00 ` Vignesh Raghavendra
2025-11-03  6:11   ` Siddharth Vadapalli
2025-11-05 13:54 ` Matthias Schiffer
2025-11-05 16:35 ` Francesco Dolcini
2025-11-09  6:22 ` Vignesh Raghavendra
2026-01-12  7:49 ` Francesco Dolcini
2026-01-12  7:56   ` Francesco Dolcini
2026-01-12 18:06     ` Tom Rini
2026-01-13 10:40       ` Siddharth Vadapalli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25c59291bdf9dbdf01d5225e20062b19f4852b28.camel@ti.com \
    --to=s-vadapalli@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=francesco@dolcini.it \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=srk@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®