From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966184AbcIYLUs (ORCPT ); Sun, 25 Sep 2016 07:20:48 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:47204 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965943AbcIYLUp (ORCPT ); Sun, 25 Sep 2016 07:20:45 -0400 Subject: Re: [PATCH 1/2] drm/tilcdc: add missing header dependencies To: Baoyou Xie , , References: <1474787805-18154-1-git-send-email-baoyou.xie@linaro.org> CC: , , , , , From: Jyri Sarha Message-ID: <25c86220-42ef-9233-69a7-2dc99b3113ea@ti.com> Date: Sun, 25 Sep 2016 14:20:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1474787805-18154-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/25/16 10:16, Baoyou Xie wrote: > We get 4 warnings when building kernel with W=1: > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:397:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes] > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:402:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes] > drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes] > drivers/gpu/drm/tilcdc/tilcdc_panel.c:453:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes] > > In fact, these functions are declared in > drivers/gpu/drm/tilcdc/tilcdc_tfp410.h, > drivers/gpu/drm/tilcdc/tilcdc_panel.h, > so this patch adds missing header dependencies. > This is at least the third time you send this same patch to me even when I replied to the first that I will pick that up: https://lkml.org/lkml/2016/9/8/429 So please stop spamming the same patch after you have got a reply from me. There is a few steps that take before the patches actually make their way to linux-next, but they will get there, don't worry. Best regards, Jyri > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 + > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > index 7b36509..2134bb20 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > @@ -25,6 +25,7 @@ > #include > > #include "tilcdc_drv.h" > +#include "tilcdc_panel.h" > > struct panel_module { > struct tilcdc_module base; > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > index c6a70da..458043a 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > @@ -23,6 +23,7 @@ > #include > > #include "tilcdc_drv.h" > +#include "tilcdc_tfp410.h" > > struct tfp410_module { > struct tilcdc_module base; >