From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D212C433F5 for ; Sat, 19 Mar 2022 05:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242051AbiCSF6p (ORCPT ); Sat, 19 Mar 2022 01:58:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233945AbiCSF6l (ORCPT ); Sat, 19 Mar 2022 01:58:41 -0400 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AB8B23D5A0 for ; Fri, 18 Mar 2022 22:57:21 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id CB8C23200C10; Sat, 19 Mar 2022 01:57:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 19 Mar 2022 01:57:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=NJi090B/iJwFRyHkW 21F4iSKRotQmY7UBQ+B5JO82Hg=; b=iLHUNTjLf3gxaY8SDVFZp64lKD9M0vTI+ aOUR8C1Q3EBTLKNFNLg57LoPU9RvLe7wUrrNRGOUNyo9yZ9oszEK3CcZSBFvBbzI of52s8xFXC11S5WkuiNSaPR1/Hu8quxOWaCNyri7JRgSxVcVlkzGAHgGkPKZU/3j 7BD/9BnMKcHtvGxxocfz+gZ98s6jhZOZNCeug+EiFwYgZXlb6k+KtN8xQM0x8DiE T00OIa2rKRNVkXiPyM1AHdKwE2OQqt0qKJPZRhS4IQnoSBQhkI9n3iqQwbjWytsM 95PnZD1wCwgwbmYJq+/kJZ3v7WonGM5UGnUf67fyeLYkH4zImEXGA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudefjedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffujgfkfhggtgesthdtredttddtvdenucfhrhhomhephfhinhhnucfv hhgrihhnuceofhhthhgrihhnsehlihhnuhigqdhmieekkhdrohhrgheqnecuggftrfgrth htvghrnhepffduhfegfedvieetudfgleeugeehkeekfeevfffhieevteelvdfhtdevffet uedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepfh hthhgrihhnsehlihhnuhigqdhmieekkhdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 19 Mar 2022 01:57:16 -0400 (EDT) Date: Sat, 19 Mar 2022 16:57:23 +1100 (AEDT) From: Finn Thain To: Randy Dunlap cc: Benjamin Herrenschmidt , Michael Ellerman , Geert Uytterhoeven , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] macintosh/via-pmu: Fix build failure when CONFIG_INPUT is disabled In-Reply-To: Message-ID: <25cb7e6c-5239-e84d-e73d-848a66a214f@linux-m68k.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Mar 2022, Randy Dunlap wrote: > > Hi Finn, > It builds without those reported errors, but I do see these warnings > since the robot-supplied .config file has: > # CONFIG_PROC_FS is not set > > > CC drivers/macintosh/via-pmu.o > ../drivers/macintosh/via-pmu.c:897:12: warning: 'pmu_battery_proc_show' defined but not used [-Wunused-function] > 897 | static int pmu_battery_proc_show(struct seq_file *m, void *v) > | ^~~~~~~~~~~~~~~~~~~~~ > ../drivers/macintosh/via-pmu.c:871:12: warning: 'pmu_irqstats_proc_show' defined but not used [-Wunused-function] > 871 | static int pmu_irqstats_proc_show(struct seq_file *m, void *v) > | ^~~~~~~~~~~~~~~~~~~~~~ > ../drivers/macintosh/via-pmu.c:860:12: warning: 'pmu_info_proc_show' defined but not used [-Wunused-function] > 860 | static int pmu_info_proc_show(struct seq_file *m, void *v) > | ^~~~~~~~~~~~~~~~~~ > I see. I'll send a separate patch for this issue.