From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752413AbeEYEMJ (ORCPT ); Fri, 25 May 2018 00:12:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:53366 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751235AbeEYEMF (ORCPT ); Fri, 25 May 2018 00:12:05 -0400 Subject: Re: [PATCH v2 5/5] MAINTAINERS: Add Actions Semi S900 pinctrl entries To: Linus Walleij Cc: Manivannan Sadhasivam , Rob Herring , liuwei@actions-semi.com, 96boards@ucrobotics.com, OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Andy Shevchenko , Daniel Thompson , Amit Kucheria , Linux ARM , GPIO SUBSYSTEM , "linux-kernel@vger.kernel.org" , hzhang@ucrobotics.com, bdong@ucrobotics.com, Mani Sadhasivam , "Thomas C. Liau" , Jeff Chen References: <20180520051736.4842-1-manivannan.sadhasivam@linaro.org> <20180520051736.4842-6-manivannan.sadhasivam@linaro.org> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Autocrypt: addr=afaerber@suse.de; prefer-encrypt=mutual; keydata= xsFNBE6W6ZQBEAC/BIukDnkVenIkK9O14UucicBIVvRB5WSMHC23msS+R2h915mW7/vXfn+V 0nrr5ECmEg/5OjujKf0x/uhJYrsxcp45nDyYCk+RYoOJmGzzUFya1GvT/c04coZ8VmgFUWGE vCfhHJro85dZUL99IoLP21VXEVlCPyIngSstikeuf14SY17LPTN1aIpGQDI2Qt8HHY1zOVWv iz53aiFLFeIVhQlBmOABH2Ifr2M9loRC9yOyGcE2GhlzgyHGlQxEVGFn/QptX6iYbtaTBTU0 c72rpmbe1Nec6hWuzSwu2uE8lF+HYcYi+22ml1XBHNMBeAdSEbSfDbwc///8QKtckUzbDvME S8j4KuqQhwvYkSg7dV9rs53WmjO2Wd4eygkC3tBhPM5s38/6CVGl3ABiWJs3kB08asUNy8Wk juusU/nRJbXDzxu1d+hv0d+s5NOBy/5+7Pa6HeyBnh1tUmCs5/f1D/cJnuzzYwAmZTHFUsfQ ygGBRRKpAVu0VxCFNPSYKW0ULi5eZV6bcj+NAhtafGsWcv8WPFXgVE8s2YU38D1VtlBvCo5/ 0MPtQORqAQ/Itag1EHHtnfuK3MBtA0fNxQbb2jha+/oMAi5hKpmB/zAlFoRtYHwjFPFldHfv Iljpe1S0rDASaF9NsQPfUBEm7dA5UUkyvvi00HZ3e7/uyBGb0QARAQABzSJBbmRyZWFzIEbD pHJiZXIgPGFmYWVyYmVyQHN1c2UuZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgID AQIeAQIXgAUCTqGJnQIZAQAKCRD6LtEtPn4BPzetD/4rF6k/HF+9U9KqykfJaWdUHJvXpI85 Roab12rQbiIrL4hVEYKrYwPEKpCf+FthXpgOq+JdTGJ831DMlTx7Ed5/QJ9KAAQuhZlSNjSc +FNobJm7EbFv9jWFjQC0JcOl17Ji1ikgRcIRDCul1nQh9jCdfh1b848GerZmzteNdT9afRJm 7rrvMqXs1Y52/dTlfIW0ygMA2n5Vv3EwykXJOPF6fRimkErKO84sFMNg0eJV9mXs+Zyionfi g2sZJfVeKjkDqjxy7sDDBZZR68I9HWq5VJQrXqQkCZUvtr6TBLI+uiDLbGRUDNxA3wgjVdS2 v9bhjYceSOHpKU+h3H2S8ju9rjhOADT2F5lUQMTSpjlzglh8IatV5rXLGkXEyum4MzMo2sCE Cr+GD6i2M3pHCtaIVV3xV0nRGALa6DdF7jBWqM54KHaKsE883kFH2+6ARcPCPrnPm7LX98h2 4VpG984ysoq6fpzHHG/KCaYCEOe1bpr3Plmmp3sqj0utA6lwzJy0hj5dqug+lqmg7QKAnxl+ porgluoY56U0X0PIVBc0yO0dWqRxtylJa9kDX/TKwFYNVddMn2NQNjOJXzx2H9hf0We7rG7+ F/vgwALVVYbiTzvp2L0XATTv/oX4BHagAa/Qc3dIsBYJH+KVhBp+ZX4uguxk4xlc2hm75b1s cqeAD87BTQROlumUARAAzd7eu+tw/52FB7xQZWDv5aF+6CAkoz7AuY4s1fo0AQQDqjLOdpQF bifdH7B8SnsA4eo0syfs+1tZW6nn9hdy1GHEMbeuvdhNwkhEfYGDYpSue7oVxB4jajKvRHAP VcewKZIxvIiZ5aSp5n1Bd7B0c0C443DHiWE/0XWSpvbU7fTzTNvdz+2OZmGtqCn610gBqScv 1BOiP3OfLly8ghxcJsos23c0mkB/1iWlzh3UMFIGrzsK3sZJ/3uRaLYFimmqqPlSwFqx3b0M 1gFdHWKfOpvQ4wwP5P10xwvqNXLWC30wB1QmJGD/X8aAoVNnGsmEL7GcWF4cLoOSRidSoccz znShE+Ap+FVDD6MRyesNT4D67l792//B38CGJRdELtNacdwazaFgxH9O85Vnd70ZC7fIcwzG yg/4ZEf96DlAvrSOnu/kgklofEYdzpZmW+Fqas6cnk6ZaHa35uHuBPesdE13MVz5TeiHGQTW xP1jbgWQJGPvJZ+htERT8SZGBQRb1paoRd1KWQ1mlr3CQvXtfA/daq8p/wL48sXrKNwedrLV iZOeJOFwfpJgsFU4xLoO/8N0RNFsnelBgWgZE3ZEctEd4BsWFUw+czYCPYfqOcJ556QUGA9y DeDcxSitpYrNIvpk4C5CHbvskVLKPIUVXxTNl8hAGo1Ahm1VbNkYlocAEQEAAcLBXwQYAQIA CQUCTpbplAIbDAAKCRD6LtEtPn4BPzA6D/9TbSBOPM99SHPX9JiEQAw4ITCBF2oTWeZQ6RJg RKpB15lzyPfyFbNSceJp9dCiwDWe+pzKaX6KYOFZ5+YTS0Ph2eCR+uT2l6Mt6esAun8dvER/ xlPDW7p88dwGUcV8mHEukWdurSEDTj8V3K29vpgvIgRq2lHCn2wqRQBGpiJAt72Vg0HxUlwN GAJNvhpeW8Yb43Ek7lWExkUgOfNsDCTvDInF8JTFtEXMnUcPxC0d/GdAuvBilL9SlmzvoDIZ 5k2k456bkY3+3/ydDvKU5WIgThydyCEQUHlmE6RdA3C1ccIrIvKjVEwSH27Pzy5jKQ78qnhv dtLLAavOXyBJnOGlNDOpOyBXfv02x91RoRiyrSIM7dKmMEINKQlAMgB/UU/6B+mvzosbs5d3 4FPzBLuuRz9WYzXmnC460m2gaEVk1GjpidBWw0yY6kgnAM3KhwCFSecqUQCvwKFDGSXDDbCr w08b3GDk40UoCoUq9xrGfhlf05TUSFTg2NlSrK7+wAEsTUgs2ZYLpHyEeftoDDnKpM4ghs/O ceCeyZUP1zSgRSjgITQp691Uli5Nd1mIzaaM8RjOE/Rw67FwgblKR6HAhSy/LYw1HVOu+Ees RAEdbtRt37A8brlb/ENxbLd9SGC8/j20FQjit7oPNMkTJDs7Uo2eb7WxOt5pSTVVqZkv7Q== Organization: SUSE Linux GmbH Message-ID: <25d1c303-71d7-8c38-880f-7bb0e133a876@suse.de> Date: Fri, 25 May 2018 06:12:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 23.05.2018 um 10:40 schrieb Linus Walleij: > On Sun, May 20, 2018 at 7:17 AM, Manivannan Sadhasivam > wrote: > >> Add S900 pinctrl entries under ARCH_ACTIONS >> >> Signed-off-by: Manivannan Sadhasivam > > Patch applied tentatively so we have some maintenance entry for this. > > Andreas expressed concerns about the driver earlier, so he might want it > split from the platform parts and have a separate entry for the pinctrl+GPIO > so Manivannan can maintain that part, also it makes sense to list > Manivannan as comaintainer of ARCH_ACTIONS with this in. > > Andreas: how would you like to proceed? > > I understand that I was a bit pushy or even rude in my last message > about the maintenance of this platform and the code structure of > the pin control driver. I am sorry if it caused any bad feelings on your > side :( social conflicts give me the creeps, I just try my best. Maybe > my best isn't always what it should be. I fail to understand how splitting the MAINTAINERS section is going to help with the pinctrl conflict at hand? The problem is that instead of refactoring my S500 pinctrl driver to his liking, Mani has submitted a competing S900 pinctrl driver that you went on to merge. The human aspect is that merging his driver took the credit away from me having written the earlier pinctrl driver (based on my rtd1295 pinctrl driver). The practical aspect is that I can't drop my pinctrl driver from my work branch until there is equivalent functionality in the merged driver. I am lacking the time to rewrite S500 pin definitions on top of Mani's myself at this time, and I haven't seen S500 patches from him yet. Also I had been investing efforts in explaining the upstreaming process to Actions, last in November. I see Thomas Liau and Jeff Chen missing in CC and I have not seen any Reviewed-by or Acked-by from anyone at Actions on this and the preceding series. There are more chips than the one on Linaro's 96board, so I would prefer to assure that the design works for all. Thus I am very critical of you applying the patches without waiting for review by Actions. Other aspects are: The reason I wrote the pinctrl driver is that I experienced a UART TX issue on the Sparky board and was hoping a pinctrl driver might resolve that, but it didn't. So I still have a mix of boards where some are working and some are pretty unusable, without any clues on why. That said, I don't object to having a separate MAINTAINERS section for the pinctrl driver(s) as long as I still get CC'ed on changes. We have wanted to add Mani as R for Actions overall, so that would probably mean adding me as R to an Actions pinctrl section, to avoid syncing the paths between two sections. I had previously felt that it does not make sense to list Mani as co-maintainer (M) for Actions overall since he can't tag and submit from my repo. And for the record I have offered him to take over which he didn't want to. I still hope to find some more time to review and queue his SPS patches, a driver that I have designed and thus understand and am much happier about the incremental additions there. A further side note is that I had reached out about setting up an infradead mailing list linux-actions, but there was no response from David or anyone. Having an L on the section(s) would avoid messing with R and hand-maintained CC lists. Any help with that appreciated. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)