From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 758AA30C356 for ; Thu, 22 Jan 2026 21:34:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769117686; cv=none; b=ADO+IKAwPM4DDaDaAkF+SqqUE+fcj1rBMamoHFvhbGr5Pg/myJ0FwGGOJ6VrE47q0WqfbV30DQR7jLTngxxwhoNcz2T+ksvY+JZlHWDTgaVVpR8gdZFTMz9eTSs/u2WpuST6ixIqEoB4pD6FIQbfPW3fCDuJYWUPCyaLPAIoaqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769117686; c=relaxed/simple; bh=Ze2NWM9t6BzojOpRtlgWdqStZabOs9WJTc/eEI2xyY8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=qLJcJSgqfZnzmtOgEftHa8Wb9oUTRzHKnpG/7zxM2MXUt/CjmRBwzpw1RJdbmH7BvCyLU4Qzfeyg98AMvUVtiLPNxcKCuwdBaR/u+f9Du6BKMCDYdMeAhIdOW9I3bxUWcIj/oRKkIc6XUODKVuQ5KLAa6phlN265Ooiv8feBGMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RnBF6H4/; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VF/eTado; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RnBF6H4/"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VF/eTado" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769117677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ze2NWM9t6BzojOpRtlgWdqStZabOs9WJTc/eEI2xyY8=; b=RnBF6H4/gUwjdptrwNskRP0Ao+j6LQnsk7lPQEdZ1Gqj9I+75Lk7Pun0/3HIlvZm47t6d6 t9lTknF5Z6zRu0T6zxT8eMUVtIglBPKBu2Jwm9P/uEMbcq5GfqWV/8JAirw/3rEjV34Oi0 x9gGMmCUD5DxhNVuzAaOfPAWDp/hDLE= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-z99JkzdXN4u87fPdkRkpqw-1; Thu, 22 Jan 2026 16:34:36 -0500 X-MC-Unique: z99JkzdXN4u87fPdkRkpqw-1 X-Mimecast-MFC-AGG-ID: z99JkzdXN4u87fPdkRkpqw_1769117675 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-88fcbe2e351so66124516d6.1 for ; Thu, 22 Jan 2026 13:34:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769117675; x=1769722475; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Ze2NWM9t6BzojOpRtlgWdqStZabOs9WJTc/eEI2xyY8=; b=VF/eTadoGa0/xV+8jY/27waD4Vu66ZbqCAUP0cJcawiWrxawe/ThdXobz6I+zCgHXt 3KnagHxok0qguxfUnTWQJQ2a1DYyYQJUdvdQH3n/iOddr821WpPErtmTow/lJHbU8II9 loyOYS3nWtc8LKOOx9KqOEZbjfYamaOutNANF504vBEGSI6u43EqWe0Us7Qdm1PXRMHd 37TM3rgB1m+TmTgfVUqoGM6OUq5ImAcLQhN7Wi8XvspDMYQez3Kklkx0dYWAikVLMjZw fWggY3z1umXsl6kwikpnWMFLDvfuSB9oaZgUOohTR9oDZRWXUO3YemzECGyAddkSfAtW uF1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769117675; x=1769722475; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ze2NWM9t6BzojOpRtlgWdqStZabOs9WJTc/eEI2xyY8=; b=PuqOUFz5oGYIuEnpyBuJTenfSD2S7BL+4x5DOT80Y+CaytcpxIiOc2eaDus3B49fqF 9wPJeySfrBPNYiQS0FDKaYk2ZM7uYYQU1A4xesbKox4ZYsYXACQNDYLnJk+yLiyYb0uU 3LFzg/Xb/b1lLdGr2/Dei6b37PD3SrTetahT67fs3tnyf4f3wpTcRqU/vx0VUMOLmcx9 RHgrVPQqxvCX5SXK7S2JDQtU6E+A9wqwoSwmQMhPjtXcM0jqXfNnzMhR+E/vkswIu4cD T1EFymVWXcKKZgFszoqdrldTe0Ja0HfQM/5z4DpSxmyTYrxET0Zk1F1B2p9fPQo6tqUL dh6A== X-Gm-Message-State: AOJu0YxJXiTXYFhvu/fBzLT9mZdkajcpXXRloyEwY5+YVlhnfJVBBIl+ FmF9E8fLxyUgXK5ZhDqIXZ0jwH0QSzMHO8e8wXSCON/yG+bTu5Jn/KpqHWTiBNHiDlQIn7y0Ssa PcwgNR5vpXPDVgQ1J7YeE/tD21Sr/5my2u7Becpncr0oX5CHo621M9JCMtW7DimQWhw== X-Gm-Gg: AZuq6aKtOtDfg2GORKBHYzBVdaZd/CYvQ7tUvlDZTXWVxtp9loeynojEy5/7JMN4Dc5 xQdjmlr1rFPxK6E8EyCj4RpQatEBtnaWO2/EUCKJfBm1vaiGUJniUtElzYOFgg92QlOpJgSlP+O eFJMDC+6TnViBTBnP84wD0ZPCr/kwevxlyw0XQ5irwHBwvnQRsItmtdOqKnZ4Cez7vn/54sO2dq q6II4TnJhqClqh9zWMvCWzd2Pie1IWvXMoFq/ESRvfRKwy7FqbaYy9ZICahWFU+H3rbcB6O3jUv 5ryO0FuKsZy5vtVH1JzdU6bgQkpkqAQNi/7AY9GNid8fpPNANbvAp2Oi4+7xExlIJ/wzg6qfuTZ P/1u4kQ== X-Received: by 2002:a05:6214:19c8:b0:892:66bb:fdbb with SMTP id 6a1803df08f44-894904b5044mr12928046d6.23.1769117675649; Thu, 22 Jan 2026 13:34:35 -0800 (PST) X-Received: by 2002:a05:6214:19c8:b0:892:66bb:fdbb with SMTP id 6a1803df08f44-894904b5044mr12927756d6.23.1769117675299; Thu, 22 Jan 2026 13:34:35 -0800 (PST) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89491824d47sm2941886d6.7.2026.01.22.13.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 13:34:34 -0800 (PST) Message-ID: <25d3c403781a88019340a47567ff85959b0c03bd.camel@redhat.com> Subject: Re: [PATCH] rust/drm: Fixup import styles From: lyude@redhat.com To: Danilo Krummrich Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, Miguel Ojeda , Simona Vetter , Alice Ryhl , Shankari Anand , David Airlie , Asahi Lina , Atharv Dubey , Daniel Almeida Date: Thu, 22 Jan 2026 16:34:32 -0500 In-Reply-To: References: <20260122202804.3209265-1-lyude@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-01-22 at 21:30 +0100, Danilo Krummrich wrote: > On Thu Jan 22, 2026 at 9:28 PM CET, Lyude Paul wrote: > > This is to match > > =C2=A0 https://docs.kernel.org/rust/coding-guidelines.html#imports > >=20 > > There should be no functional changes in this patch. >=20 > Thanks! While at it, can you please drop imports that are in prelude > and use > prelude instead? Just a random musing - it would actually be quite nice if we could have some sort of automated style check for this. I have to assume the linux kernel probably isn't the only project out there with its own prelude=E2=80= =A6