Re: [PATCH 8/9] clk: samsung: gs101: Enable auto_clock_gate mode for each gs101 CMU

[Krzysztof Kozlowski <krzk@kernel.org>]

On 21/10/2025 23:03, Peter Griffin wrote:
>>> +}
>>> +
>>>  static void __init gs101_cmu_misc_init(struct device_node *np)
>>>  {
>>> +     if (check_cmu_res_size(np))
>>> +             return;
>>
>> You will not register CMU on old DTB.
> 
> By "compatible" I meant the driver detects an old DTB with an
> incorrect reg size and issues an error message on the console to
> update your DT (as opposed to crashing trying to access a register
> that hasn't been mapped).


That's not being compatible. You should not break anything here if size
is smaller - just fallback to previous manual mode.

> 
> Is it enough to re-word the commit message to make it clearer what will happen?
> 
> An alternative might be to try registering all the gates in manual
> mode, but that seems like it would add more complexity for not much
> benefit. It would also require that clk_ignore_unused kernel parameter
> to have been passed (as manual clock mode has never worked without it)
> and whilst it might boot today I imagine it would bitrot fast as
> additional CMUs are added (and thus probably crash in a much more
> obscure way).
> 
> Peter

Best regards,
Krzysztof