From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A610E3B7B7B for ; Wed, 24 Jun 2026 15:08:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782313723; cv=none; b=H6HPNbfGWdFlnFteiDkovjzTowHcdEgXqDKrJOAvWuTkaZAdhaAjqxZIfZr0s4vYobnqcQ12cA3WBO1xFXkraJ7A0MkVAUZYWJEwH7xZqgtl83OTbQ3yIbgVu0f3vlXCf32RZpIpPymj9Sw7HGdqYXy7qVtdMKkFWiwF3YlKA44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782313723; c=relaxed/simple; bh=ha588Qy7P13tI/5EXyd8p2my8LC+7wLyzZpLl5hWR7g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oaSLnPLtqmufHVk9Xj39mm5NBhptdnJ7YNaU3qailIncJi8pSyZ2xd82b6TF07kosPTI3dGBxnYpn9TXkHDirwG8BZldMRzD2aP3MhLkDeFr4QH9amU95ODm2OarR20nnoVTm4SejOFF9fVHGh/jmaCKF3EDqRtFc/chyx14HVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=afyu830T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HNsikH0O; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="afyu830T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HNsikH0O" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65OEfF9t3707827 for ; Wed, 24 Jun 2026 15:08:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j3GdgZ+o5lITYD2ZGmitJILxX6Tbi6MycbzRQo9WHWM=; b=afyu830Txnvo8Xao EZ7atpr+S7VLhmcX9qYrjzY5Lqqzeuc5iSV+Zato7jsh/aTVxmXBsCeeBODUci1J NuolLEzxP6FlVCDxAQxea964qdYfrDcHsIzPv2+luXZrDwIRgrK1K0lySP2wkk5O qtmW4RCtq6nsVNJgQUy1+opVVJKfGr73cSQQ1WnF2Rkgzhn0PKuFcBDiz5++nU1e 76Vw9kMSmMcFb/+shPVMZTBV5fKQVEpQrnphBWCWbwd+tqC9wUJdMg5PQgkJeWa3 gj7iiGYDlJ1xZ7MMHuJ+/WjeekSOyuz6NrbWhdbrUIM4zeAVa39hAfPIYO0n+62h rJmbqw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f05ajjw9p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Jun 2026 15:08:40 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-37d125687b6so1531811a91.1 for ; Wed, 24 Jun 2026 08:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782313719; x=1782918519; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j3GdgZ+o5lITYD2ZGmitJILxX6Tbi6MycbzRQo9WHWM=; b=HNsikH0ONLxQIZD8TYv/0zPWPGAeVs67vDyFzKQCtSsi5FKhcO2ZU4+2L7m8c3S40Q CmiGxzXxq6qqFGarbyZCiXkS3fRYr86zVoWfEbbsVR1H/wdhKrg9V7fye/bfuLC438W6 EV+baFCvTGXAglrA8TAXg9+/tnREYRG0zfgiIoQHhl5BLBFbHndF1SuFliu9AtGLG1kE vpwOGDoyzBqUh7GZWdS6MPSot/0tYSjWST4aUSSl1BEe6hGob1++qYL09GpHNlO/fb81 ZfXkQ8RK4n6GomMZQj3rnwCZDna5+p4NB6A90wkVz4iD4/PVi2X2s6n6v6omdCKOGD0m Pn1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782313719; x=1782918519; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j3GdgZ+o5lITYD2ZGmitJILxX6Tbi6MycbzRQo9WHWM=; b=TXpCxnN29uu8YmL1qkyzOcivvyvtNHCQ3Lprml5f4UqU7YAkucbUZnb4jXDHXkvGkZ 0roBVGegsM1OtsVwydwoRK/Qgu8IUH1JgqRHPm64Rn03qxdfGGrvXexGZSyTka7gG/rE GfvMBo41LEvVvLPKjS3LetDeVOsFUEBO4fHmLTLl/Z8YcnLdjYtLLleTowi38z7wqhgl dbwElCeuykI1OwuPw+OvtnD/saM0gse+zloejia3KRRETtRV/RGqZGGdGIb1pNzcijWI c03yJ4lZuZLuejUHNTb4zei+Cym8q3JR6SCLa4VHwRBF/YUM/Y0ndctyslWLq9OsvKNA wXuA== X-Forwarded-Encrypted: i=1; AHgh+RoplpZ64hDlrL0XprnpvkLXw8rIBfR1R44ii1/HDXzJH0F0ggBEXs7Uv2vJsVDckOjPsdt630ByRMZcpFw=@vger.kernel.org X-Gm-Message-State: AOJu0YyOynladQz2eovluDX30byMsOaJt6sNe0b926X2cMddqWN4Yxe8 JwMoeCrOkL/Vi75+URzOLdJzDB2tNJifJmZ/NBXzk6+1g+hjyddD9p8PLdNsP6P2NokPn1W+Jm8 ZLxBz38jL6k86gJqPey77SeGOkuM3GdSjmla/HFQ7vAPlsxhWbw7sEkZ5UQ2pxFFU8c0= X-Gm-Gg: AfdE7cnQ8BLLdqZe0V+R/xkz4A7uuZg28wfPWWxaRrtD4/PeLfAn4o8wSpryaCYJxvA QhksYuBUsmxZEHuFC28SbM1w8kXXe9A3hUyr9UFf9gRMIpQMF8NfHJruJEcGX5xhhl4BlYATiTh ZQxj7aFIIOejFuoYUPxPN8d1GlK6Rwwnk+CyRF3Ot2vu0/tDjIt2ZqqNuzCJpcXGOMhw4qrKiro Vkl+Z93jIGiubqL09IV9X0dbMALmGmIzLgavUb1/vN8jsK5eX9W/W0LACgiCauCSWXKYEKMmXy+ h9MDotd8kU02g6YRQZY8AQzh8AzanJ6+BmAE3H65SYlLLEPfNcJ8Leu3zbVhszHSLD8uFMcVPYX xlA/GdY7YK0T7eUg054nxzLb1HReRB8ya7mnwPioNdaLXVB6WTZsNnTJnxM5nZJTcfOlvT+YRQK EU X-Received: by 2002:a17:90b:5242:b0:37c:6505:e7c3 with SMTP id 98e67ed59e1d1-37dd0dec9famr9384579a91.22.1782313719556; Wed, 24 Jun 2026 08:08:39 -0700 (PDT) X-Received: by 2002:a17:90b:5242:b0:37c:6505:e7c3 with SMTP id 98e67ed59e1d1-37dd0dec9famr9384520a91.22.1782313719042; Wed, 24 Jun 2026 08:08:39 -0700 (PDT) Received: from [10.133.33.213] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37de3bbc38asm2684833a91.0.2026.06.24.08.08.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 08:08:38 -0700 (PDT) Message-ID: <25d7d3a1-58e0-4f25-a73a-59a978130c47@oss.qualcomm.com> Date: Wed, 24 Jun 2026 23:08:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: kaanapali: fix traceNoC probe issue To: Suzuki K Poulose , Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Mike Leach , James Clark , Leo Yan , Yuanfang Zhang Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20260624-fix-tracenoc-probe-issue-v2-0-786520f62f21@oss.qualcomm.com> <20260624-fix-tracenoc-probe-issue-v2-2-786520f62f21@oss.qualcomm.com> <471d7a92-3629-4274-a303-8906d3626037@arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <471d7a92-3629-4274-a303-8906d3626037@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI0MDEyNyBTYWx0ZWRfX6VZb6dAI+TV6 l0XYocYSkmHHTrUgVedw3JNgQCDvp0PqA7ibfXeZ6yo72FOFmdGo0kzrcOPnbdC2g4Dub/8kPbm w8xt+MkAGtYt+0zts/WPDbZF4f9nn8w= X-Proofpoint-GUID: lIWc9w-QflkdOJg8ULUb4p5nZIC4EEQE X-Proofpoint-ORIG-GUID: lIWc9w-QflkdOJg8ULUb4p5nZIC4EEQE X-Authority-Analysis: v=2.4 cv=DbUnbPtW c=1 sm=1 tr=0 ts=6a3bf2f8 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=3Q5jxKAVfJmP3VMBrLwA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI0MDEyNyBTYWx0ZWRfX8LvljJew6RUI YfLtOIDOYr3mZ7bEkg1a+i0Qu3kW6J0RYbYWCyIxKBdTGnMqgX7loz5CiO5xQ93ZJRRunR3fMq2 mOMAw0UPHWVTJ2PXU+amGVBrLflBb4lAQ2CRCZCRvN2KJ+u20Q9VDEJ41AfH/MoXGK+sgDksmMT TcB3LVe/2cErBMI8mRSpTxRzKcsdAp8go2uiYhjH1nrJ8OVc0Hkg0kn50nw7Q4eIUdz2cPWcbIn de/GURY2XIOlFBTWsvpNBsZ+NL1Iv+pq1JECwzk4hiwjTTkh84cmJvBYMQ92LNi2HKsuaghbTS9 kT5TPxXzI302bepyQNjGHarN1w+Afsz9iuy/B/2mEznGp7nKV2J6jeLIxEkYj0bZrFr2iOgkejU MLmB+DXu6Dhnn3IWmRgJrsxjOK0qTQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_03,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606240127 On 6/24/2026 9:51 PM, Suzuki K Poulose wrote: > On 24/06/2026 14:48, Jie Gan wrote: >> >> >> On 6/24/2026 9:27 PM, Konrad Dybcio wrote: >>> On 6/24/26 11:49 AM, Jie Gan wrote: >>>> The AMBA bus attempts to read the CID/PID of a device before invoking >>>> its probe function if the arm,primecell-periphid property is absent. >>>> This causes a deferred probe issue for the TraceNoC device, as the >>>> CID/PID cannot be read from the periphid register. >>> >>> Why does it probe defer? >>> >> >> For an AMBA device, the periphid is mandatory for probing. In the >> amba_match function, AMBA attempts to read the periphid from the CID/ >> PID registers if the arm,primecell-periphid property is absent in the >> device tree. If this read fails, it returns -EPROBE_DEFER, and the >> probe ultimately fails. > > Why does it fail ? power management ? hw broken ? Is it really AMBA or > do you pretend that to be an AMBA device by faking the CID/PID? The CID reads as 0 from the register, which I suspect is a hardware design issue. I have not yet confirmed this with the hardware team. As a workaround, I provided a fake periphid via a DT property to bypass amba_read_periphid. Leo commented in other thread: >>tnoc.c registers both an AMBA driver and a platform driver. Shouldn't >>it >>be registered as a platform device instead? The platform driver is intended for the interconnect TraceNoC device and is not designed to allocate an ATID. The issue is that the TPDM device borrows the ATID from the TraceNoC device, resulting in the ATID always being 0 when associated with an interconnect NoC device. However, I believe it is acceptable to allocate an ATID for the itNoC device and the issue can be fixed with this way. Thanks, Jie > > Suzuki > > >> Most AMBA devices expose valid CID/PID registers, so specifying >> arm,primecell-periphid in the device tree is usually unnecessary. >> However, for the TraceNoC device in this case, AMBA cannot reliably >> read the periphid from the corresponding registers. >> >>> And is this required for all TNOC devices? >> >> So far, the TNOC device has been added to sm8750, Glymur, and >> Kaanapali platforms, and all exhibit probe failures due to the same >> root cause. >> >> I prefer to fix it on Kaanapali first. >> >> Thanks, >> Jie >> >>> >>> Konrad >> >