From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 3/4] gpio-stmpe: Move an assignment in stmpe_gpio_probe()
Date: Fri, 12 Jan 2018 21:03:35 +0100 [thread overview]
Message-ID: <25ddf208-1f02-8bb7-b6b8-e0ffa422b754@users.sourceforge.net> (raw)
In-Reply-To: <df11c007-360e-ce6b-2f70-61b6fb6b49cf@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 12 Jan 2018 20:44:15 +0100
Move the assignment for the local variable "irq" so that its setting
will only be performed directly before it is checked by this function.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpio/gpio-stmpe.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c
index 2cf30dcba82a..d51e27eb1c59 100644
--- a/drivers/gpio/gpio-stmpe.c
+++ b/drivers/gpio/gpio-stmpe.c
@@ -435,8 +435,6 @@ static int stmpe_gpio_probe(struct platform_device *pdev)
int ret;
int irq = 0;
- irq = platform_get_irq(pdev, 0);
-
stmpe_gpio = kzalloc(sizeof(*stmpe_gpio), GFP_KERNEL);
if (!stmpe_gpio)
return -ENOMEM;
@@ -459,6 +457,7 @@ static int stmpe_gpio_probe(struct platform_device *pdev)
if (stmpe_gpio->norequest_mask)
stmpe_gpio->chip.irq.need_valid_mask = true;
+ irq = platform_get_irq(pdev, 0);
if (irq < 0)
dev_info(&pdev->dev,
"device configured in no-irq mode: "
--
2.15.1
next prev parent reply other threads:[~2018-01-12 20:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 20:00 [PATCH 0/4] gpio-stmpe: Adjustments for two function implementations SF Markus Elfring
2018-01-12 20:01 ` [PATCH 1/4] gpio-stmpe: Use seq_putc() in stmpe_dbg_show() SF Markus Elfring
2018-01-16 9:59 ` Linus Walleij
2018-01-12 20:02 ` [PATCH 2/4] gpio-stmpe: Improve a size determination in stmpe_gpio_probe() SF Markus Elfring
2018-01-16 10:00 ` Linus Walleij
2018-01-12 20:03 ` SF Markus Elfring [this message]
2018-01-16 10:03 ` [PATCH 3/4] gpio-stmpe: Move an assignment " Linus Walleij
2018-01-12 20:04 ` [PATCH 4/4] gpio-stmpe: Delete an unnecessary variable initialisation " SF Markus Elfring
2018-01-16 10:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ddf208-1f02-8bb7-b6b8-e0ffa422b754@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome