From: roel kluin <roel.kluin@gmail.com>
To: Kumar Gopalpet-B05799 <B05799@freescale.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gianfar: Fix tests of unsigneds in gfar_parse_group()
Date: Wed, 16 Dec 2009 16:48:00 +0100 [thread overview]
Message-ID: <25e057c00912160748x504cb4c1ibaa3ab6d26864525@mail.gmail.com> (raw)
In-Reply-To: <9F4C7D19E8361D4C94921B95BE08B81BA08D5A@zin33exm22.fsl.freescale.net>
On Wed, Dec 16, 2009 at 6:04 AM, Kumar Gopalpet-B05799
<B05799@freescale.com> wrote:
>
>>Won't it be better to change types of interruptTransmit,
>>-Receive and -Error in struct gfar_priv_grp itself. Something
>>like this:
> struct gfar_priv_grp {
> ....
> - unsigned int interruptTransmit;
> - unsigned int interruptReceive;
> - unsigned int interruptError;
>
> + int interruptTransmit;
> + int interruptReceive;
> + int interruptError;
> ....
> }
>
> --
>
> Thanks
> Sandeep
I don't think that's better. Only the error returned is signed,
If none occurred the irq thereafter is unsigned.
Thanks,
Roel
prev parent reply other threads:[~2009-12-16 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 18:42 Roel Kluin
2009-12-16 5:02 ` Kumar Gopalpet-B05799
2009-12-16 5:04 ` Kumar Gopalpet-B05799
2009-12-16 15:48 ` roel kluin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25e057c00912160748x504cb4c1ibaa3ab6d26864525@mail.gmail.com \
--to=roel.kluin@gmail.com \
--cc=B05799@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®