From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9708B2EAB6F for ; Mon, 3 Aug 2026 01:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785721838; cv=none; b=Rv7E1Wgb2GbzvzAIfLXhnpv7928pgGbJHQNAtKu4K/aCSS0XLp3tje2n8LW1BWzOUBVDNsrIMmbZow0H3Va5OGZz3TrRlz6aqxAgITu+umYLKT+VmhUuJgzhL11yHuSqsMewF/7WTVz50xmKaeXIosu5n9P7Z5qcFeNK7NYsUYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785721838; c=relaxed/simple; bh=Ych7km7RzdMH+A8V9KC6uTYgA8GFtn3ofOlpfhw3vDQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ctAJXk37PnGXxmuhYn+4vZXJ/Lq+4hxzqTg7VikupIKneJTGjvEhsN8cKQ+124XV8plDL2NCWKw8dRG6bRVOSb4B0ekhRgxmG+ZnM/DRZLjjqgjGc7zJ5c+isDGAzwo6Woc+uWYFZZaeUza+OFMjKBJk0vC1cx4wdbsXu6Kut2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d9AwetZ8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SBveNKPs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d9AwetZ8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SBveNKPs" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 672LVriG2594702 for ; Mon, 3 Aug 2026 01:50:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xIFd94f6C79s+yG6r78sDfN4bOnzyywCIv/Jsn+QDnk=; b=d9AwetZ8/fOTLIiY j6iAnBCBv8kYHvnrZAYwo4H4nrQkV5V0q4XK2DcvPHsPbJkYQcmRYyXBm/kN7eaK Ra4QCcn1JLDlctnuA1PCScn7eCTk9zDhH5xDZYvX0uzhxeTOfPQMxusJIfrHyZw+ El/cMF8vxUye1reD53tp7MC9gaIgibXXwmbnaWQt8FtBgjEzMDjcdCUumB7Qs0MJ xqP6R3HgS4LBAyNgYPuTZQdDd2lktWOPdTWGFjmVrl1KlufBoqs0FFMMaM0fZhTW /OliSamIcS20swslH260VNY/drV+RZRdhdp5Alcx9KMsIAC572qYUcZP9hxMACMd 0JBCQg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fs966c0a1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 01:50:35 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38ec0f510a9so7296429a91.2 for ; Sun, 02 Aug 2026 18:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785721834; x=1786326634; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xIFd94f6C79s+yG6r78sDfN4bOnzyywCIv/Jsn+QDnk=; b=SBveNKPsq6H9Y9rPjdTIWdSIFofuegrKouOZc8vdSXXQkU0WeQ3puLGx9aMZY2qh+N NgcZxs16cz739Q7BcXBv3N/bRLa6Quyx2fFCL60tXV03dyHwD4O3XUz1VnyFjtOu4dnw j46NxBJTLNjF0p+0N6IqJN+9I3DyaR3x7srnPxbb5bIiZgqYky3cVqjmSk+NE2jxtGKh 4TPMKjyNjHET3nHdoRvQVhnSBu8T/FdxE4ra2unS+sj0I4AdRHdrejPgq+LGDEMCKKBM 4BeW86/f38l/UNPPFBvxVcNQafpbTR0SuSNk9PXMmTQ4UccMvgA8tPVGwVEeTSSbibyD g39A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785721834; x=1786326634; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xIFd94f6C79s+yG6r78sDfN4bOnzyywCIv/Jsn+QDnk=; b=KC4MXuF9p1yzvPOsdGvHJB+KOGKbO1qm59kZ5E2OuPqKeZ7dY4ovkhtT1n4oakHoZq 7DvN1TCwWOuPl5ly6p7S9Uv4cYXAY6yc/6sC7WuvwJzkxAgHOmVUBnLhT8HG7+lQX7k4 J6sv1yCkczyLBXkzVlLrTY1GWeDGVc3GxR55n3n5BKkYMn/MFtleVt7akA1DsWFulG6g ja5adJYawndl5I8xxg/QE499UEmkCN2bfIkh97O1T9SuZpFgx9uBfReBl8CfrLEP+50n 9cVzR/hzCQpBq23ODNBDvS6kyMwgy+yzniDr86oTqOny+h4TyanpOffk7BoFeAUIgsZq qjjg== X-Forwarded-Encrypted: i=1; AHgh+Rp3bbHn/oAlxPJqx1hnX0ZhSaSOpYkkOMiOJaStdiMaBxtPKFoLDImn1cPcqtzHt0nxog0MlDMUMURD2Io=@vger.kernel.org X-Gm-Message-State: AOJu0YxILOW3Q8l0dsMX7QmSZudl3FaDHml7WhHcQ52N41YnXQ0jix7l +cuo3Ymd91cH94iwVsTwV4gh11up3ekcwyQnwGsJ7ybg63jLhjLoQS8cB5RkYGCN9+0X6MDcaXN dWh1CHL338gBV7ryXLmffgBkFSW4pvxNUkSGfVVFnaVp1i14y/tGqEzXP8ASfslT3dfY= X-Gm-Gg: AR+sD11jwJBIbSTXmrQdDgtF7BwoKAoqER6RP7BCfViFdD62GG3j7HyU/HvUJaR8jja iD5LyIzB49Pva4Ku/x5O9Gx4282LXvzv0bayhfOhKpO5MbmNSUEMg5LeyC43ew5T3acAtqjKcH7 mwAbcX+oV/FT6S41RfQShNGtZR6DYGPgUGgHWNqiN9Vv3Yxuk2+x1I5PJJGfL1LHhbK4OFYa9Rs 1V04bnBBHff+VFVE32ZmfDlOrqtcFnn1L58jkyKseOxlBXGK1GRu1QC5aqpiWNyK0W5eVhZOSGL gKiRwPbaRZPUoATFD19thLtCpamgfZ2GF6QO/6phF1i8VQDHIrpFLUSaKA9UEFR885RQfM8U1iV 7PfX+gePH+geUhfquCu9XN+58g3GvOW5NFfhGX3oi17ziYInmxsa/A+fCefBn/SapBGri X-Received: by 2002:a17:90b:3c05:b0:38e:101f:c867 with SMTP id 98e67ed59e1d1-38fbc4896afmr7526778a91.18.1785721834343; Sun, 02 Aug 2026 18:50:34 -0700 (PDT) X-Received: by 2002:a17:90b:3c05:b0:38e:101f:c867 with SMTP id 98e67ed59e1d1-38fbc4896afmr7526760a91.18.1785721833849; Sun, 02 Aug 2026 18:50:33 -0700 (PDT) Received: from [10.133.33.59] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb2575819sm3263683a91.0.2026.08.02.18.50.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Aug 2026 18:50:33 -0700 (PDT) Message-ID: <25e0797b-fdb3-44b2-8ea5-df0bc3355648@oss.qualcomm.com> Date: Mon, 3 Aug 2026 09:50:29 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] leds: rgb: leds-qcom-lpg: Add PWM frequency mode support To: Konrad Dybcio , linux-arm-msm@vger.kernel.org, Lee Jones , Pavel Machek Cc: David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260729-lpg-pwm-fm-support-v1-1-16d3c72a9921@oss.qualcomm.com> <7a0c4a70-b838-4c7c-9f16-d394ffef95ba@oss.qualcomm.com> Content-Language: en-US From: Fenglin Wu In-Reply-To: <7a0c4a70-b838-4c7c-9f16-d394ffef95ba@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: oepbAx41iQXodR8SITyGrK490nYRCVVw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDAxMiBTYWx0ZWRfX11Bbv3Ez1o3b LPRYMQUm03HaBbaU0r7t9f8EvqJns7+Q5tKMTJ8XnONk0OC8vp+5jcXdNXOqYvpEYSuC2JEmwO4 0Hdq5GuWIQaoGLI0Uf1pS35rjT1B6OuacAgGRZb6DUqOkg0/WKEAqgxwbf49wvqAB2tk7DPDt/a Y1jGH1V2qd/yYv/jWHZtjPEOwNjvDN6ZL8nGN2fFVmvvdOyngahxpgKSd+jtf/7BeaJ9uhw7Wu+ u3mnD3iMM+58aMKxwxVzaw1MDEn/CD5HeyVTztTpb5ml820KXsWy39uBRinkQlA9zWKqVjMf0d+ XJ5ICxyY17KBnPlW2l4Np1MzaB9J+tiiv1F+rI7rAO0E2eY4CXSY9WhiS/dpfJPGPuB8T+P5Hbt nS7UpTDpPkd7Uifh7MfV4x+1PsLps04jiNHAL1l8YCOe3lI7IluuDtEDHs+Hju708A/2t+en4Sp fvPhVidQuxBWjVAA/QQ== X-Authority-Analysis: v=2.4 cv=TpfWQjXh c=1 sm=1 tr=0 ts=6a6ff3eb cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=Jk1indnoN2tpaKD3vp0A:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: oepbAx41iQXodR8SITyGrK490nYRCVVw X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDAxMiBTYWx0ZWRfXwrBz9pmpQQKP TkQM1/j0o39frcc1r+KZe7j5DLy5nw6SwX1S69ZzXiypUh9aOTnJiya0kSvvKB6/1MJY8WbbS9X EWu2OwysigMRJjVep1uMOXhrvWFXscs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_06,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030012 On 7/31/2026 10:20 PM, Konrad Dybcio wrote: >> regmap_read(lpg->map, chan->base + LPG_SUBTYPE_REG, &chan->subtype); >> + if (data->channels[i].fm_capable) { >> + ret = regmap_read(lpg->map, chan->base + PWM_STATUS1_REG, &status); >> + if (ret < 0) >> + return ret; >> + >> + chan->fm_capable = !!(status & PWM_FM_PRESENT); > Can we read this register blindly by chance and drop the match data? It would result unnecessary read for the PWM channels which don't support frequency mode. The register read here is actually just for differentiating the HW revisions for pm8350c, where only the V2 support frequency mode. And the newer variants of pm8350c PWM4 channel could support frequency mode by default. Thanks Fenglin