From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<lvc-project@linuxtesting.org>,
Eddie Huang <eddie.huang@mediatek.com>,
Long Cheng <long.cheng@mediatek.com>
Subject: Re: [PATCH v2] serial: 8250_mtk: correct max baud rate in set_termios() method
Date: Tue, 14 Oct 2025 19:50:16 +0300 [thread overview]
Message-ID: <25e098b2-d786-437c-ad92-eccb90b148f7@omp.ru> (raw)
In-Reply-To: <20251014130050-5cdb9e464558d609872d38cc-pchelkin@ispras>
On 10/14/25 1:07 PM, Fedor Pchelkin wrote:
>> Mediatek MT798x datasheets (that I was able to get my hands on) claim
Thank you, Fedor, BTW! :-)
>> the maximum supported baud rate to be 3 Mbps, while commit 81bb549fdf14
>> ("serial: 8250_mtk: support big baud rate.") claimed it to be 4 Mbps --
>
> At least MT7987A datasheet claims to support up to 4 Mbps, so I think 4 Mbps
> should be chosen for the upper limit.
FTR, this SoC doesn't seem to be supported by the mainline kernel (looking
at Linus' repo, at least).
I think, we should "parametrize" the max (and maybe even min?) baud rate
adding more specific compatibles to mtk8250_of_match[] (and probably setting
this parameter to 4 Mbps for the existing entry)...
> + added the authors of 81bb549fdf14 ("serial: 8250_mtk: support big baud rate.")
> to Cc.
Just noticed that the author of this "wonderful" patch didn't even sign off
on it. "Excellent" work! :-/
> --
> Fedor
MBR, Sergey
prev parent reply other threads:[~2025-10-14 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-12 17:56 Sergey Shtylyov
2025-10-14 10:07 ` Fedor Pchelkin
2025-10-14 16:50 ` Sergey Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25e098b2-d786-437c-ad92-eccb90b148f7@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=angelogioacchino.delregno@collabora.com \
--cc=eddie.huang@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=long.cheng@mediatek.com \
--cc=lvc-project@linuxtesting.org \
--cc=matthias.bgg@gmail.com \
--cc=pchelkin@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®